1375166 - [mozlint] Can't run single file with |mach eslint|

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, defect)

Description

[Andrew Halberstadt [:ahal]]

This is a regression from bug 1288432. Running ./mach eslint <path/to/file.js> does not lint the file. This happens because mozlint is expecting the 'extensions' [1] to start with a period.

This is silly, mozlint should strip any leading periods if found.

[1] https://dxr.mozilla.org/mozilla-central/rev/e1e4a481b7e88dce163b9cccc2fb72032023befa/tools/lint/eslint.yml#8

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1375166 - [mozlint] Don't require leading '.' in extensions,

This was a regression from bug 1288432. The 'extensions' config in mozlint required a
leading period, but eslint requires them without the period (and this got copied over
to the linter definition). The result was mozlint filtering out any files (not dirs)
that were passed in.

This just modifies mozlint to strip out the period so both are acceptable.

Review commit: https://reviewboard.mozilla.org/r/151388/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/151388/

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 8880059 [details]
Bug 1375166 - [mozlint] Don't require leading '.' in extensions,

https://reviewboard.mozilla.org/r/151388/#review156780

Looks great, thank you.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2b190948b81b
[mozlint] Don't require leading '.' in extensions, r=standard8

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2b190948b81b