Closed Bug 1375254 Opened 3 years ago Closed 2 years ago

JSON Viewer treats primitives as syntax error

Categories

(DevTools :: JSON Viewer, enhancement)

enhancement
Not set

Tracking

(firefox56 fixed)

RESOLVED FIXED
Firefox 56
Tracking Status
firefox56 --- fixed

People

(Reporter: Oriol, Assigned: Oriol)

Details

Attachments

(1 file)

They are not valid JSON according to RFC-4627, but they are allowed by ECMA-404.

I think they should be displayed using Reps.

Currently data:application/json,"123" and data:application/json,123 are indistinguishable.
Assignee: nobody → oriol-bugzilla
Status: NEW → ASSIGNED
Attachment #8886372 - Flags: review?(odvarko)
Comment on attachment 8886372 [details] [diff] [review]
json-primitives.patch

Review of attachment 8886372 [details] [diff] [review]:
-----------------------------------------------------------------

Looks reasonable to me, thanks for fixing this Oriol!

Honza
Attachment #8886372 - Flags: review?(odvarko) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a8ed7c1808df
Make JSON Viewer display primitive values using Reps. r=Honza
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a8ed7c1808df
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.