Closed
Bug 1375387
Opened 7 years ago
Closed 7 years ago
Reorder and section-ify GeckoProfiler.h
Categories
(Core :: Gecko Profiler, enhancement)
Core
Gecko Profiler
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
Details
Attachments
(2 files)
39.03 KB,
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
22.16 KB,
text/plain
|
Details |
GeckoProfiler.h's order is totally random. I'd like to make it have some sense.
Assignee | ||
Comment 1•7 years ago
|
||
The diff is hard to read. I will attach a copy of the new GeckoProfiler.h, which you can read directly.
Attachment #8880252 -
Flags: review?(mstange)
Assignee | ||
Comment 2•7 years ago
|
||
Comment 3•7 years ago
|
||
Comment on attachment 8880252 [details] [diff] [review] Reorder and section-ify GeckoProfiler.h Review of attachment 8880252 [details] [diff] [review]: ----------------------------------------------------------------- ::: tools/profiler/public/GeckoProfiler.h @@ +42,2 @@ > class ProfilerMarkerPayload; > class SpliceableJSONWriter; At some point we should probably move these classes into the mozilla namespace as well, because they don't have an "ns" prefix.
Attachment #8880252 -
Flags: review?(mstange) → review+
Assignee | ||
Comment 4•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/a43c10bf081edc622b1c47ba8aeef15265c8536b Bug 1375387 - Reorder and section-ify GeckoProfiler.h. r=mstange.
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a43c10bf081e
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•