Closed Bug 1375398 Opened 2 years ago Closed 2 years ago

dom/media/CubebUtils.cpp:60:41: error: 'VsprintfLiteral' was not declared in this scope

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox-esr52 --- unaffected
firefox54 --- unaffected
firefox55 --- unaffected
firefox56 --- fixed

People

(Reporter: jbeich, Assigned: jbeich)

References

Details

(Keywords: regression)

Attachments

(1 file)

On platforms without GeckoProfiler (iOS, Linux non-x86, BSDs, Solaris) one of required headers is no longer pulled via unification with dom/media/AudioStream.cpp.

In file included from objdir/dom/media/Unified_cpp_dom_media2.cpp:11:
dom/media/CubebUtils.cpp:60:3: error: use of undeclared identifier 'VsprintfLiteral'
  VsprintfLiteral (buffer, aFmt, arglist);
  ^
1 error generated.
If you want such errors detected automatically see bug 1371159.
Summary: /dom/media/CubebUtils.cpp:60:41: error: 'VsprintfLiteral' was not declared in thi s scope → dom/media/CubebUtils.cpp:60:41: error: 'VsprintfLiteral' was not declared in this scope
Example bootlegging vector on Tier1 platforms:

In file included from objdir/dom/media/Unified_cpp_dom_media2.cpp:2:
In file included from dom/media/CanvasCaptureMediaStream.cpp:6:
In file included from dom/media/CanvasCaptureMediaStream.h:9:
In file included from dom/media/DOMMediaStream.h:9:
In file included from objdir/dist/include/ImageContainer.h:15:
In file included from objdir/dist/include/mozilla/ReentrantMonitor.h:13:
objdir/dist/include/GeckoProfiler.h:431:2: error: test
Comment on attachment 8880267 [details]
Bug 1375398 - Unbreak build without Gecko Profiler after bug 1374389.

https://reviewboard.mozilla.org/r/151624/#review156606

I thought I had found them all :(
didn't think to disable some options though...
Attachment #8880267 - Flags: review?(jyavenard) → review+
Keywords: checkin-needed
Pushed by jyavenard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/247a9e959aae
Unbreak build without Gecko Profiler after bug 1374389. r=jya
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/247a9e959aae
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Assignee: nobody → jbeich
You need to log in before you can comment on or make changes to this bug.