1375426 - Rewrite socorro.external.postgres.graphics_report to use Super Search

Status: RESOLVED FIXED

(Socorro :: Webapp, task)

Description

[[DEACTIVATED] Adrian Gaudebert]

Feature URL
-----------

https://crash-stats.mozilla.com/graphics_report/?date=2017-06-22

Parts impacted
--------------

 * socorro, external.postgres.graphics_report

Rationals
---------

 * it depends on the `reports` table in Postgres, which we want to remove
 * Elasticsearch, via Super Search, should be the only source of crash data and aggregations

Other possible outcome
----------------------

It is possible that we want to work this out differently. This report is only used by the Firefox graphics team. We could ask them to run the query to Super Search themselves, instead of hitting an endpoint on our end.

It might also be worth verifying that this feature is still useful, and if not, simply remove it.

Comment 1

[Peter Bengtsson [:peterbe]]

I have a prototype to just rewrite this in SuperSearch. Once landed we can reinstate the conversation with the graphics team. 
The conclusion when we last talked to them is that they need this and that'd be unlikely to change. 
The reason is that they have historical graphs that goes back longer than *our* retention policy and if they can continue to use the existing technique new data would align with old data and they'd get the historical perspective they want.

A rewrite (on the inside) is a stepping stone. We can later trying to convince them to do the exact same thing as the rewrite does but via HTTP API. Mind you, it'll always be faster if we do it in our web server I suspect.

Comment 2

[Peter Bengtsson [:peterbe]]

PR https://github.com/mozilla-services/socorro/pull/3831

Adrian, I asked you for a review because you're the most familiar with the webapp and SuperSearch. 
I'm not interested in obsessing too much over this. The output seems to work. 

The git commit doesn't automatically close this bug. That's because we need to think about if it's worth to ask the graphics team to extract out my piece of Python inside that view and rewrite it to use `requests.get` instead of `models.SuperSearch().get`. Really not sure it's worth it.

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/c061cade9fe99989631a11f9e764d3d1510b5dae
bug 1375426 - rewrite graphics report with SuperSearch (#3831)

* bug 1375426 - rewrite graphics report with SuperSearch

* oops

* review comments

* nits addressed

Comment 4

[Peter Bengtsson [:peterbe]]

I change my mind. I think this bug should be only about *our* code and what we can do. If the graphics team wants it they can do the same SuperSearch that https://github.com/mozilla-services/socorro/commit/c061cade9fe99989631a11f9e764d3d1510b5dae does but now it's built and maintained.