Closed Bug 1375430 Opened 7 years ago Closed 5 years ago

Firefox does not prompt for password save when no form submit event is fired

Categories

(Toolkit :: Password Manager, defect, P3)

All
Other
defect

Tracking

()

RESOLVED INCOMPLETE

People

(Reporter: miha.sustersic.work, Unassigned)

References

Details

(Whiteboard: [specification][type:bug])

What did you do?
================
I have a simple login form in a react app that I am developing.

This is the form inside my component:
```html
<form>
  Username<br/>
  <input className='login-input' placeholder='Username' name='username' type='text' onChange={this.onInputChange}/>
  <br/>
  Password:<br/>
  <input className='login-input' id='password' name='password' type='password' onChange={this.onInputChange}/>
</form>
```

I tried tweaking firefox setting according to the official docs, running in safe mode and disabling hardware acceleration. The best I could achieve was saving the username in safe mode, but in normal mode, and without hardware acceleration nothing happens.

What happened?
==============
When I open the app in safari or Chrome, I get a propmt to save the user password when the Input values are submitted using an external button. But in Firefox, n propmt is opened, the page just redirect to the rest of the app.

What should have happened?
==========================
A propmt should have opened asking to save the user credentials.

Is there anything else we should know?
======================================
This is the actual DOM element rendered in the browser:
```html
<form>
  <!-- react-text: 6 -->Username
  <!-- /react-text --><br><input type="text" class="login-input" placeholder="Username" name="username"><br>
  <!-- react-text: 10 -->Password:
  <!-- /react-text --><br><input type="password" class="login-input" id="password" name="password">
</form>
```
Component: General → Untriaged
Product: Mozilla Developer Network → Firefox
Component: Untriaged → Password Manager
Product: Firefox → Toolkit
It sounds like you're not actually using a submit event (e.g. via <button>, <input type=submit>, form.submit()) which is the proper way to submit forms. Is that correct? If you switch to following web standards like that then it will work. If you don't actually want the page to navigate then you can still use

If you don't use a real form submission you'll have to wait for bug 1287202 for our heuristics to detect this.
Depends on: 1287202
Flags: needinfo?(miha.sustersic.work)
Priority: -- → P3
Summary: Firefox does not propmt for password save → Firefox does not prompt for password save when no form submit event is fired

Can you please confirm that your form works with tomorrow's Firefox Nightly version now that bug 1287202 is fixed? https://nightly.mozilla.org/

Status: UNCONFIRMED → NEW
Ever confirmed: true
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → INCOMPLETE
Flags: needinfo?(miha.sustersic.work)
You need to log in before you can comment on or make changes to this bug.