1375463 - Move contextmenu related tests into browser/base/content/test/contextMenu

Status: RESOLVED FIXED

(Firefox :: Menus, enhancement, P3)

Description

[Johann Hofmann [:johannh]]

Bug 1299371 added a tests/contextMenu directory, so we should probably move

browser_contextmenu.js
browser_contextmenu_childprocess.js
browser_contextmenu_input.js

into that folder.

Comment 1

[Mark Banner (:standard8)]

I'm happy to mentor this. Here's some notes for what to do:

• An artifact build is sufficient for checking your changes.
• The test files listed in comment 0 should be moved from browser/base/content/test/general to browser/base/content/test/contextMenu
• References in the test/general/browser.ini file should be moved across to the test/contentMenu/browser.ini file.
  • Include any lines following until the next test is listed, but remove the comment lines that start with # DO NOT ADD ...
• Other support files are referenced from the test files (I think they all have contextmenu in the name).
  • These should also be moved across and the associated references in browser.ini updated.
• Once you've moved everything, run these commands:
  • ./mach build
  • ./mach mochitest browser/base/content/test/contextMenu
  • ./mach mochitest browser/base/content/test/general
• If all the commands are successful, then you should be good to post this patch.
  • Create a commit with a message such as Bug 1375463 - Move contextmenu related tests into browser/base/content/test/contextMenu. r?Standard8
  • Post it using Phabricator

Comment 2

[matthewacha]

I would like to take this on @standard8

Comment 3

[SresthaSrivastava [:srestha]]

Can I take this up?

Comment 4

[Mark Banner (:standard8)]

Sorry everyone, I just realised I'd forgotten to actually cc myself on this bug so I'd missed notifications :-(

@matthewacha, since you commented first, would you still like to take this on?

Comment 5

[Ahmed ali]

can i take this @standard8 ?it would be my first contribution .

Comment 6

[Mark Banner (:standard8)]

Hi Ahmed, please let matthewacha have a chance to respond first.

Comment 7

[matthewacha]

thanks, I will get onto it right away

Comment 8

[SresthaSrivastava [:srestha]]

Hey @matthewacha, if you're not working on this, can I take this up?

Comment 9

[matthewacha]

Attachment: Bug 1375463 - Move contextmenu related tests into browser/base/content/test/contextMenu. r?Standard8

Comment 10

[afshan.shokath]

Hello,
Can I take this up? This will be my first contribution.

Comment 11

[Mark Banner (:standard8)]

(In reply to afshan.shokath from comment #10)

Can I take this up? This will be my first contribution.

Sorry, Matthewacha is already working on this. You can find more possible bugs at https://codetribute.mozilla.org/

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/baae6f2fe9a7
Move contextmenu related tests into browser/base/content/test/contextMenu. r=Standard8

Comment 13

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/baae6f2fe9a7