Move contextmenu related tests into browser/base/content/test/contextMenu

RESOLVED FIXED in Firefox 68

Status

()

enhancement
P3
normal
RESOLVED FIXED
2 years ago
Last month

People

(Reporter: johannh, Assigned: matthewacha, Mentored)

Tracking

(Blocks 1 bug, {good-first-bug})

unspecified
Firefox 68
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 wontfix, firefox68 fixed)

Details

(Whiteboard: [lang=js])

Attachments

(1 attachment)

Reporter

Description

2 years ago
Bug 1299371 added a tests/contextMenu directory, so we should probably move

browser_contextmenu.js
browser_contextmenu_childprocess.js
browser_contextmenu_input.js

into that folder.
Reporter

Updated

2 years ago
Summary: Move contextmenu related tests into browser/base/content/tests/contextMenu → Move contextmenu related tests into browser/base/content/test/contextMenu
Component: General → Tabbed Browser
Priority: -- → P3

I'm happy to mentor this. Here's some notes for what to do:

  • An artifact build is sufficient for checking your changes.
  • The test files listed in comment 0 should be moved from browser/base/content/test/general to browser/base/content/test/contextMenu
  • References in the test/general/browser.ini file should be moved across to the test/contentMenu/browser.ini file.
    • Include any lines following until the next test is listed, but remove the comment lines that start with # DO NOT ADD ...
  • Other support files are referenced from the test files (I think they all have contextmenu in the name).
    • These should also be moved across and the associated references in browser.ini updated.
  • Once you've moved everything, run these commands:
    • ./mach build
    • ./mach mochitest browser/base/content/test/contextMenu
    • ./mach mochitest browser/base/content/test/general
  • If all the commands are successful, then you should be good to post this patch.
    • Create a commit with a message such as Bug 1375463 - Move contextmenu related tests into browser/base/content/test/contextMenu. r?Standard8
    • Post it using Phabricator
Mentor: standard8
Component: Tabbed Browser → Menus
Keywords: good-first-bug
Whiteboard: [lang=js]
Assignee

Comment 2

5 months ago

I would like to take this on @standard8

Can I take this up?

Sorry everyone, I just realised I'd forgotten to actually cc myself on this bug so I'd missed notifications :-(

@matthewacha, since you commented first, would you still like to take this on?

Flags: needinfo?(matthewacha)

Comment 5

4 months ago

can i take this @standard8 ?it would be my first contribution .

Flags: needinfo?(standard8)

Hi Ahmed, please let matthewacha have a chance to respond first.

Assignee: nobody → eng.ahmedaliahmed535
Flags: needinfo?(standard8)
Assignee: eng.ahmedaliahmed535 → matthewacha
Assignee

Comment 7

4 months ago

thanks, I will get onto it right away

Flags: needinfo?(matthewacha)

Hey @matthewacha, if you're not working on this, can I take this up?

Comment 10

3 months ago

Hello,
Can I take this up? This will be my first contribution.

(In reply to afshan.shokath from comment #10)

Can I take this up? This will be my first contribution.

Sorry, Matthewacha is already working on this. You can find more possible bugs at https://codetribute.mozilla.org/

Comment 12

Last month
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/baae6f2fe9a7
Move contextmenu related tests into browser/base/content/test/contextMenu. r=Standard8

Comment 13

Last month
bugherder
Status: NEW → RESOLVED
Closed: Last month
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
You need to log in before you can comment on or make changes to this bug.