1375493 - Consider not flushing from HTMLEditor::GetAbsolutelyPositionedSelectionContainer()

Status: NEW

(Core :: DOM: Editor, defect, P2)

Description

[(no longer active)]

I think this function can probably be switched to use nsComputedDOMStyle::GetStyleContextNoFlush() to avoid a style flush.  This means that it could be using relatively stale style information, which is currently probably an issue given where this is called <https://searchfox.org/mozilla-central/rev/ae94cfb36d804727dfb38f2750bfcaab4621df6e/editor/libeditor/HTMLEditorObjectResizer.cpp#92>, but some testing may be needed.  It may be a good idea to somehow move this to happen after the style flush that happens as part of the refresh driver tick.

Comment 2

[Makoto Kato [:m_kato]]

That is by bug 47066...

Comment 3

[Makoto Kato [:m_kato]]

mozilla::HTMLEditor::GetAbsolutelyPositionedSelectionContainer checks whether current element has position:aboslute.  But does it require computedstyle?

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

We probably could just move CheckSelectionStateForAnonymousButtons to be called around tick time.
Less hacky than use possibly stale position information.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Attachment: v1

remote: View your changes here:
remote:   https://hg.mozilla.org/try/rev/132471a256965ed09d46bbd6ce86caebc6520dc4
remote:   https://hg.mozilla.org/try/rev/be39eb7c806ebd5f65a39c64a987c7c6d17374ce
remote:   https://hg.mozilla.org/try/rev/dfa510ebba6329c1acf7971678c37c744fe0f9bb
remote:   https://hg.mozilla.org/try/rev/74e9778977684fed9c42e1d72dc3c1a2b7190d04
remote:   https://hg.mozilla.org/try/rev/61b618ada13d3f744e52215eada0f1e805fbd8e3
remote: 
remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=61b618ada13d3f744e52215eada0f1e805fbd8e3