1375571 - Move Android resource usage out of mobile/android/services

Status: NEW

(Firefox Build System :: Android Studio and Gradle Integration, defect)

Description

[Nick Alexander :nalexander [he/him]]

This is a step toward Bug 1229149.  This ticket tracks getting rid of org.mozilla.gecko.R from mobile/android/services; that'll make it much, much easier to build the code as a Gradle module.

I see only a handful of org.mozilla.gecko.R references:
- some can be removed (fxaccount_remote_error_* strings);
- some can be worked around with some kind of dependency injection (default strings used for client names and bookmark folder name);
- the hard part is moving FxAccountStatusActivity to mobile/android/base (and I don't know how hard that is).

Comment 1

[Nick Alexander :nalexander [he/him]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=eb559c0acf3a

Comment 2

[Nick Alexander :nalexander [he/him]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=77b8a45b445b

Comment 3

[Nick Alexander :nalexander [he/him]]

Attachment: Bug 1375571 - Part 1: Remove unused fxaccount_remote_error_* strings.

This is follow-up to Bug 1220892, which just forgot to remove these strings.

Review commit: https://reviewboard.mozilla.org/r/154990/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/154990/

Comment 4

[:Grisha Kruglov]

Comment on attachment 8884031 [details]
Bug 1375571 - Part 1: Remove unused fxaccount_remote_error_* strings.

https://reviewboard.mozilla.org/r/154990/#review160044

nice!

Comment 5

[Nick Alexander :nalexander [he/him]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a3ce2dca41a0ded688bfda38269bb7f6f17a2f8b