Move Android resource usage out of mobile/android/services

NEW
Unassigned

Status

()

Firefox for Android
Build Config & IDE Support
8 months ago
27 days ago

People

(Reporter: nalexander, Unassigned)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

8 months ago
This is a step toward Bug 1229149.  This ticket tracks getting rid of org.mozilla.gecko.R from mobile/android/services; that'll make it much, much easier to build the code as a Gradle module.

I see only a handful of org.mozilla.gecko.R references:
- some can be removed (fxaccount_remote_error_* strings);
- some can be worked around with some kind of dependency injection (default strings used for client names and bookmark folder name);
- the hard part is moving FxAccountStatusActivity to mobile/android/base (and I don't know how hard that is).
Comment hidden (mozreview-request)

Comment 4

8 months ago
mozreview-review
Comment on attachment 8884031 [details]
Bug 1375571 - Part 1: Remove unused fxaccount_remote_error_* strings.

https://reviewboard.mozilla.org/r/154990/#review160044

nice!
Attachment #8884031 - Flags: review?(gkruglov) → review+
Component: Build & Test → Build Config & IDE Support
Product: Android Background Services → Firefox for Android
You need to log in before you can comment on or make changes to this bug.