1375691 - Make RadioNodeList final and cleanup the code using it

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P3)

Comment 1

[Mats Palmgren (inactive)]

Attachment: Make RadioNodeList final and cleanup the code using it

The data in the mRequiredRadioButtonCounts hashtable is either a content node,
or a RadioNodeList.  We know this because that's what this class inserts
and no one else has direct access to it.  So it's a bit silly pretend it
might be something else using nsIDOMNodeList/nsINodeList/nsBaseContentList.

Let's just MOZ_ASSERT it's a RadioNodeList unless it QI's to nsIContent.
Also, make the RadioNodeList class final to enable the compiler to
devirtualize some calls.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3be13bca20672995fe600211b3a9f15799305931

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8880632 [details] [diff] [review]
Make RadioNodeList final and cleanup the code using it

r=me; I expects this code dates back to when there was multiple inheritance from nsISupports going on here; e.g. before bug 460512 was fixed, when we had:

  class nsBaseContentList : public nsIDOMNodeList,
                            public nsINodeList

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0db8583ea48c
Make RadioNodeList final and cleanup the code using it.  r=bz

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0db8583ea48c