Closed Bug 1375692 Opened 4 years ago Closed 4 years ago

Indicate support for Stylo in about:support

Categories

(Core :: CSS Parsing and Computation, enhancement, P3)

enhancement

Tracking

()

VERIFIED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: gps, Assigned: jryans)

References

Details

Attachments

(1 file, 1 obsolete file)

In bug 1374824, a few people posted somewhat esoteric ways to identify if Stylo is enabled in a build. As was suggested in bug 1374824 comment #29, I think it would be a good idea to indicate Stylo state in about:support.
I probably won't finish this patch because I'm not sure of the technical requirements for a) identifying Style state at run-time b) requirements for adding things to about:support. Although if someone points me in the right direction, I may finish it :)
Thanks :gps, I think I'll take it from here.  I'd also like to have something in about:support. :)
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Priority: -- → P3
Comment on attachment 8881504 [details]
Bug 1375692 - Add Stylo status to about:support.

https://reviewboard.mozilla.org/r/152654/#review157834

I'm certainly not a peer in the about:support code but this looks great to me. I'll leave it up to you whether you need domain-specific review or not.

Thanks for doing this!
Attachment #8881504 - Flags: review?(bobbyholley) → review+
From what I could see, there did not appear to be specific about:support peers (it has been reviewed by a grab bag of people over time), so hopefully this review is sufficient.
Pushed by jryans@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/7f1958b128c2
Add Stylo status to about:support. r=bholley
https://hg.mozilla.org/mozilla-central/rev/7f1958b128c2
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
(In reply to Carsten Book [:Tomcat] from comment #11)
> https://hg.mozilla.org/mozilla-central/rev/7f1958b128c2

Nit:
> +disabledByUser = disabled by user
> \ No newline at end of file
Seen in today's 20170630100234 @ Debian Testing x64 (Radeon RX480). Thank you!

* Stylo: false (disabled by default)
* Stylo: true (enabled by user)
Status: RESOLVED → VERIFIED
(In reply to Darkspirit from comment #13)
> Seen in today's 20170630100234 @ Debian Testing x64 (Radeon RX480). Thank
> you!

Thank you for all the detailed testing! It's been really invaluable to guide our focus this week and knock out the most important issues. :-)
You need to log in before you can comment on or make changes to this bug.