1375698 - Cleanup nsDocument::GetBoxObjectFor

Status: RESOLVED FIXED

(Core :: XUL, enhancement, P3)

Description

[Mats Palmgren (inactive)]

We can replace do_CreateInstance(contractID) with "new BoxObject",
remove unnecessary error handling since "new" is infallible.
Also, use RefPtr<BoxObject> for the mBoxObjectTable hashtable because
that's what's stored there, not some abstract nsPIBoxObject.

Comment 1

[Mats Palmgren (inactive)]

Attachment: part 1 - Call "new BoxObject" instead of do_CreateInstance(contractID) and remove some unnecessary error handling since "new" is infallible

Using #ifdef MOZ_XUL mostly as "this can be removed some day".
I doubt our code actually builds without it currently.

Comment 2

[Mats Palmgren (inactive)]

Attachment: part 2 - Make mBoxObjectTable a nsRefPtrHashtable of BoxObject instead of nsInterfaceHashtable of nsPIBoxObject (that we then need to downcast)

(Bug 1375696 will cleanup the unnecessary hashtable lookups here)

Comment 3

[Mats Palmgren (inactive)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3be13bca20672995fe600211b3a9f15799305931

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8880633 [details] [diff] [review]
part 1 - Call "new BoxObject" instead of do_CreateInstance(contractID) and remove some unnecessary error handling since "new" is infallible

r=me.  Thank you for doing this.

We might want a followup to get rid of all this contractid/CID/NS_New* gunk for box objects, after 57 ships.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8880634 [details] [diff] [review]
part 2 - Make mBoxObjectTable a nsRefPtrHashtable of BoxObject instead of nsInterfaceHashtable of nsPIBoxObject (that we then need to downcast)

r=me

Comment 6

[Mats Palmgren (inactive)]

(In reply to Boris Zbarsky [:bz] (if a patch has no decent message, automatic r-) from comment #4)
> We might want a followup to get rid of all this contractid/CID/NS_New* gunk
> for box objects, after 57 ships.

Filed bug 1376125.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c9213679fdcf
part 1 - Call "new BoxObject" instead of do_CreateInstance(contractID) and remove some unnecessary error handling since "new" is infallible.  r=bz
https://hg.mozilla.org/integration/mozilla-inbound/rev/c9f4980873ab
part 2 - Make mBoxObjectTable a nsRefPtrHashtable of BoxObject instead of nsInterfaceHashtable of nsPIBoxObject (that we then need to downcast).  r=bz

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c9213679fdcf
https://hg.mozilla.org/mozilla-central/rev/c9f4980873ab