treeherder reports "Complete" when there's still a build left

RESOLVED FIXED

Status

Tree Management
Treeherder
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: dbaron, Assigned: KWierso)

Tracking

Details

Attachments

(2 attachments)

Created attachment 8880676 [details]
screenshot

On https://treeherder.mozilla.org/#/jobs?repo=try&revision=e782864da7d5a8c2af169fd0613e0a3e7e1b568b&group_state=expanded I'm seeing a try run that treeherder says is "Complete" but there's still a tc-M-e10s-6 that still needs to finish.  The problem persisted across Shift-Reload (although now that I'm done typing this in, it finished).
(Assignee)

Comment 1

a year ago
There's a bit of rounding in the calculations for completion[1]. When it gets to be near the end with a lot of finished jobs, I guess it rounds up to 100%?




1. https://github.com/mozilla/treeherder/blob/be8c7be9ad3bf17541849dc8aaf5b051be0d0435/ui/js/directives/treeherder/resultsets.js#L21
Created attachment 8880678 [details] [review]
[treeherder] KWierso:percentfix > mozilla:master
(Assignee)

Updated

a year ago
Assignee: nobody → wkocher
(Assignee)

Comment 3

a year ago
Comment on attachment 8880678 [details] [review]
[treeherder] KWierso:percentfix > mozilla:master

How about this? If rounding pushes percentComplete up to 100% but there's still at least one job in-progress, we push percentComplete down to 99%, making it not show as "Complete".
Attachment #8880678 - Flags: review?(emorley)
Comment on attachment 8880678 [details] [review]
[treeherder] KWierso:percentfix > mozilla:master

Left some comments :-)
Attachment #8880678 - Flags: review?(emorley) → review-
(Assignee)

Updated

a year ago
Attachment #8880678 - Flags: review- → review?(emorley)
Comment on attachment 8880678 [details] [review]
[treeherder] KWierso:percentfix > mozilla:master

Left a comment :-)
Attachment #8880678 - Flags: review?(emorley) → review-
(Assignee)

Updated

a year ago
Attachment #8880678 - Flags: review- → review?(emorley)
Comment on attachment 8880678 [details] [review]
[treeherder] KWierso:percentfix > mozilla:master

Many thanks! :-)
Attachment #8880678 - Flags: review?(emorley) → review+

Comment 7

a year ago
Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/d7fda53b7380dad8a126a54408aa8117dd88876e
Bug 1375722 - Just drop everything after the decimal point to avoid rounding up to 100% (#2591)
(Assignee)

Updated

a year ago
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.