1375722 - treeherder reports "Complete" when there's still a build left

Status: RESOLVED FIXED

(Tree Management :: Treeherder, enhancement)

Description

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: screenshot

On https://treeherder.mozilla.org/#/jobs?repo=try&revision=e782864da7d5a8c2af169fd0613e0a3e7e1b568b&group_state=expanded I'm seeing a try run that treeherder says is "Complete" but there's still a tc-M-e10s-6 that still needs to finish.  The problem persisted across Shift-Reload (although now that I'm done typing this in, it finished).

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

There's a bit of rounding in the calculations for completion[1]. When it gets to be near the end with a lot of finished jobs, I guess it rounds up to 100%?




1. https://github.com/mozilla/treeherder/blob/be8c7be9ad3bf17541849dc8aaf5b051be0d0435/ui/js/directives/treeherder/resultsets.js#L21

Comment 2

[GitHub Autolander Bot]

Attachment: [treeherder] KWierso:percentfix > mozilla:master

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Comment on attachment 8880678 [details] [review]
[treeherder] KWierso:percentfix > mozilla:master

How about this? If rounding pushes percentComplete up to 100% but there's still at least one job in-progress, we push percentComplete down to 99%, making it not show as "Complete".

Comment 4

[Ed Morley [:emorley]]

Comment on attachment 8880678 [details] [review]
[treeherder] KWierso:percentfix > mozilla:master

Left some comments :-)

Comment 5

[Ed Morley [:emorley]]

Comment on attachment 8880678 [details] [review]
[treeherder] KWierso:percentfix > mozilla:master

Left a comment :-)

Comment 6

[Ed Morley [:emorley]]

Comment on attachment 8880678 [details] [review]
[treeherder] KWierso:percentfix > mozilla:master

Many thanks! :-)

Comment 7

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/d7fda53b7380dad8a126a54408aa8117dd88876e
Bug 1375722 - Just drop everything after the decimal point to avoid rounding up to 100% (#2591)