Closed Bug 1375749 Opened 2 years ago Closed 2 years ago

Intermittent /service-workers/service-worker/xhr.https.html | application crashed [@ RefPtr<mozilla::dom::FetchBody<mozilla::dom::Response> >::operator->]

Categories

(Core :: DOM: Service Workers, defect, critical)

defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox-esr52 --- unaffected
firefox54 --- unaffected
firefox55 --- unaffected
firefox56 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: baku)

References

Details

(Keywords: crash, intermittent-failure, regression)

Crash Data

Attachments

(1 file)

Duplicate of this bug: 1375768
Assignee: nobody → amarchesini
Attached patch crash.patchSplinter Review
I was able to reproduce it. Basically we release objects because the window goes away or the worker is released, but in the meantime we have a runnable in the queue for finishing the body consumption. When that runnable is executed, we crash because data has been already released.
Attachment #8881855 - Flags: review?(bkelly)
Attachment #8881855 - Flags: review?(bkelly) → review+
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7c5cc1b39c89
Avoid FetchConsumer::ContinueConsumeBody() to be called more than once, r=bkelly
Duplicate of this bug: 1376282
https://hg.mozilla.org/mozilla-central/rev/7c5cc1b39c89
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Do you want to request uplift to beta 55?
Flags: needinfo?(amarchesini)
Looks like this is taken care of in bug 1371889.
Flags: needinfo?(amarchesini)
Keywords: regression
Blocks: 1381748
This won't be landing on 55.
No longer blocks: 1381748
Depends on: 1381748
You need to log in before you can comment on or make changes to this bug.