1375776 - Reduce usage of MOZ_GECKO_PROFILER some more

Status: RESOLVED FIXED

(Core :: Gecko Profiler, enhancement)

Description

[Nicholas Nethercote [inactive]]

Because it's still worth reducing the number of places that check MOZ_GECKO_PROFILER.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: (part 1) - Fix a comment about the PseudoStack

The JS Engine now has a PseudoStack pointer, rather than a pointer and two
sizes.

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: (part 2) - Combine the two TracingMarkerPayload constructors

Comment 3

[Nicholas Nethercote [inactive]]

Attachment: (part 3) - Improve destructor of ProfilerMarkerPayload and its subclasses

No point having all these explicit empty destructors.

Also, we can avoid IOMarkerPayload's constructor by using a UniqueFreePtr.

Comment 4

[Nicholas Nethercote [inactive]]

Attachment: (part 4) - Allow ProfilerMarkerPayload.h to be #included unconditionally

This requires:

- Moving the constructors of ProfilerMarkerPayload and its subclasses into the
  .h file so they are visible even when ProfilerMarkerPayload.cpp isn't
  compiled.

- Similarly, using a macro to make StreamPayload() a crashing no-op when the
  profiler isn't enabled. (It is never called in that case.)

Comment 5

[Nicholas Nethercote [inactive]]

Attachment: (part 5) - Pass in a TimeStamp to LayerTranslationMarkerPayload()

This makes it more like all the other payload classes.

Comment 6

[Nicholas Nethercote [inactive]]

Attachment: (part 6) - Remove Nursery::trackTimings_

If these timings are on for all MOZ_GECKO_PROFILER platforms (i.e. all tier 1
platforms) then we might as well simplify things by having them on for all
platforms.

Comment 7

[Nicholas Nethercote [inactive]]

Attachment: (part 7) - Add a comment to ThreadInfo

Comment 8

[Shu-yu Guo [:shu]]

Comment on attachment 8882950 [details] [diff] [review]
(part 1) - Fix a comment about the PseudoStack

Review of attachment 8882950 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you, meticulous as always.

Comment 9

[Markus Stange [:mstange]]

Comment on attachment 8882952 [details] [diff] [review]
(part 3) - Improve destructor of ProfilerMarkerPayload and its subclasses

Review of attachment 8882952 [details] [diff] [review]:
-----------------------------------------------------------------

Having out-of-line empty destructors can sometimes help with reducing the number of includes in a header file. E.g. if your class has a UniquePtr<SomeClass> mMember, the place where you destroy mMember determines whether you need to #include "SomeClass.h" in the header or in the cpp file (so that the UniquePtr destructor can call ~SomeClass).
But it doesn't seem like that concern applies here.

Comment 10

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/06895769b545612905059cdca1b09d275fa38818
Bug 1375776 (part 1) - Fix a comment about the PseudoStack. r=shu.

https://hg.mozilla.org/integration/mozilla-inbound/rev/80eebfa22250464e8cf226bc5af14a491242ab13
Bug 1375776 (part 2) - Combine the two TracingMarkerPayload constructors. r=mstange.

https://hg.mozilla.org/integration/mozilla-inbound/rev/e2c80991b84d16a20d5f49322639b699b417f162
Bug 1375776 (part 3) - Improve destructor of ProfilerMarkerPayload and its subclasses. r=mstange.

https://hg.mozilla.org/integration/mozilla-inbound/rev/cf412ab85156a34b36f60a9bba6d8f2a6ecc06f7
Bug 1375776 (part 4) - Allow ProfilerMarkerPayload.h to be #included unconditionally. r=mstange.

https://hg.mozilla.org/integration/mozilla-inbound/rev/9adcd10aa3a94ee89812fd48661598f99a0ed65c
Bug 1375776 (part 5) - Pass in a TimeStamp to LayerTranslationMarkerPayload(). r=mstange.

https://hg.mozilla.org/integration/mozilla-inbound/rev/6088329750411865a6340205a9757d136cef8801
Bug 1375776 (part 6) - Remove Nursery::trackTimings_. r=sfink.

https://hg.mozilla.org/integration/mozilla-inbound/rev/8d3fcb61cc736bc8269a926ab3265fa9b0d9b8e5
Bug 1375776 (part 7) - Add a comment to ThreadInfo. r=mstange.

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/06895769b545
https://hg.mozilla.org/mozilla-central/rev/80eebfa22250
https://hg.mozilla.org/mozilla-central/rev/e2c80991b84d
https://hg.mozilla.org/mozilla-central/rev/cf412ab85156
https://hg.mozilla.org/mozilla-central/rev/9adcd10aa3a9
https://hg.mozilla.org/mozilla-central/rev/608832975041
https://hg.mozilla.org/mozilla-central/rev/8d3fcb61cc73