1375781 - `hg qbackout` thinks servo ref is a bug number

Status: RESOLVED FIXED

(Developer Services :: Mercurial: qbackout, enhancement)

Description

[Carsten Book [:Tomcat]]

Glob asked me to backout de9bb450199d https://hg.mozilla.org/integration/autoland/rev/de9bb450199d from autoland.

While doing this i noticed that hg backout think that the servo: Merge #17452 id is bug 17452, so https://hg.mozilla.org/integration/autoland/rev/de9bb450199d lists also in the bug section that bug.

This is not so critical but if we don't be super concentrated on this and miss this, we might end up with comments in the bugs that have nothing to do with the backout....in that case it would have been a 18 year old bug :)

Comment 1

[Gregory Szorc [:gps]]

Where exactly is the bug? There's one in the hgweb /rev/ URL linking to https://bugzilla.mozilla.org/show_bug.cgi?id=17452. Not sure if it is just that or something else.

Comment 2

[Carsten Book [:Tomcat]]

Hey Gps, the problem is that in case of a backout that hg backout think the servo push id like 17452 is the bug - id - so it creates a backout message like backedout changeset id 1234 (bug 17452) - and that leads to wrong comments in the bug - so hg backout should ignore that servo ref id / not handle as bug id - but not sure if this is doable

Comment 3

[:glob ✱]

oops, didn't mean to set that ni

Comment 4

[:glob ✱]

Attachment: qbackout: only match on bugs that are preceded by 'bug' (bug 1375781)

qbackout currently matches on servo's "Merge #12345", incorrectly treating
12345 as a bug number.  switch to requiring "bug 12345".

Review commit: https://reviewboard.mozilla.org/r/153686/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/153686/

Comment 5

[Gregory Szorc [:gps]]

Comment on attachment 8882593 [details]
qbackout: only match on bugs that are preceded by 'bug' (bug 1375781)

https://reviewboard.mozilla.org/r/153686/#review160788

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/72b7800ab16f
qbackout: only match on bugs that are preceded by 'bug' r=gps