If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

[doc] add tips to create a patch in making-prs.md

RESOLVED FIXED in Firefox 56

Status

()

Firefox
Developer Tools
P3
enhancement
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: jdescottes, Assigned: jdescottes)

Tracking

unspecified
Firefox 56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

3 months ago
The current doc for making-prs.md mentions that patches should be attached to bugzilla without any indication on how to generate such patches.

It also contains a section about using a `gist` command which doesn't seem to work anymore.
Comment hidden (mozreview-request)
(Assignee)

Comment 2

3 months ago
:sole, let me know if you want me to mention something different for Git. Ideally I would like this to simply be about a few easy steps to have a patch ready, for first time contributors.

I removed the Gist section from the doc because it didn't work for me when trying locally and it's not clear how it's useful for our workflow anyway.

Comment 3

3 months ago
mozreview-review
Comment on attachment 8880759 [details]
Bug 1375800 - [doc] add tips to create a patch file in devtools docs;

https://reviewboard.mozilla.org/r/152128/#review157182

Ah that's great! thank you for spotting this and fixing it!

Two suggestions - they can be follow up:

1) use "Creating" instead of "Crafting", which sounds like you're an artisan and doesn't really add anything, but confuse readers (is "Creating" different from "crafting"? and how? etc)
2) I actually think the instructions in https://developer.mozilla.org/en-US/docs/Tools/Contributing#Creating_a_patch_to_check_in should be in this wiki, perhaps you can file a bug to migrate them here? They overlap with our contributing doc, and the most interesting part is the git patch bit, and sending attachments when you do not have commit access. This lowers the barrier of entry...
Attachment #8880759 - Flags: review?(sole) → review+
(Assignee)

Updated

3 months ago
See Also: → bug 1375850
Comment hidden (mozreview-request)

Comment 5

3 months ago
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/aa2f5375836a
[doc] add tips to create a patch file in devtools docs;r=sole
(Assignee)

Comment 6

3 months ago
Thanks for the review, Sole!
- updated crafting to creating 
- logged Bug 1375850 to migrate the MDN contributing page to our docs

Comment 7

3 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/aa2f5375836a
Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
You need to log in before you can comment on or make changes to this bug.