Closed Bug 1375847 Opened 2 years ago Closed 2 years ago

Add skeleton U2FHIDTokenManager

Categories

(Core :: DOM: Device Interfaces, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: ttaubert, Assigned: ttaubert)

References

Details

(Whiteboard: [webauthn])

Attachments

(1 file)

We should start by adding a skeleton U2FHIDTokenManager that returns NS_ERROR_NOT_IMPLEMENTED for ::Register() and ::Sign(). We can then start calling the Rust library and implement the full transport interface.
Comment on attachment 8880804 [details] [diff] [review]
0003-Bug-1375847-Add-skeleton-U2FHIDTokenManager-r-qDot.patch

Review of attachment 8880804 [details] [diff] [review]:
-----------------------------------------------------------------

Needs a commit message. :p Otherwise looks fine.
Attachment #8880804 - Flags: review?(kyle) → review-
(In reply to Kyle Machulis [:qdot] [:kmachulis] from comment #2)
> Needs a commit message. :p Otherwise looks fine.

It actually has a commit message, a few sentences after the subject line :) Is that not enough or should it be improved?
Flags: needinfo?(kyle)
After 6 years of splinter use you'd think I'd be used to the UI, and yet...

r+'d, sorry. :)
Flags: needinfo?(kyle)
https://hg.mozilla.org/mozilla-central/rev/3984855684f9
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.