Update pinned-tab highlight/glow style for Photon

RESOLVED FIXED in Firefox 56

Status

()

Firefox
Theme
P1
normal
RESOLVED FIXED
2 months ago
8 days ago

People

(Reporter: Dolske, Assigned: Dolske)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 56
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify +

Firefox Tracking Flags

(firefox56 fixed)

Details

(Whiteboard: [photon-visual][p2])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

2 months ago
The current highlight/glow on pinned tabs (used as a notification to indicate when the title has changed) doesn't work so well with the dark titlebar from bug 1367384 / bug 1367385. The Photon mocks show this as changing to a small blue dot.

Updated

2 months ago
Whiteboard: [photon-visual] → [photon-visual] [triage]

Updated

2 months ago
Blocks: 1355767
No longer blocks: 1349555
Flags: qe-verify+
Priority: -- → P2
Whiteboard: [photon-visual] [triage] → [photon-visual][p2]

Updated

2 months ago
QA Contact: brindusa.tot
(Assignee)

Comment 1

2 months ago
Created attachment 8882094 [details] [diff] [review]
Patch v.1

I checked with Stephen -- this is the SVG from his demo mockup, and is fine to use. And the single image/color is fine for the default/light/dark themes.
Assignee: nobody → dolske
Attachment #8882094 - Flags: review?(dao+bmo)

Updated

2 months ago
Status: NEW → ASSIGNED
Priority: P2 → P1

Comment 2

2 months ago
Comment on attachment 8882094 [details] [diff] [review]
Patch v.1

>--- a/browser/themes/shared/compacttheme.inc.css
>+++ b/browser/themes/shared/compacttheme.inc.css

>+%ifdef MOZ_PHOTON_THEME
>+  --pinned-tab-glow-url: url(chrome://browser/skin/tabbrowser/indicator-tab-attention.svg);

>@@ -84,7 +88,11 @@ toolbar:-moz-lwtheme-brighttext  {
>   --tab-selection-color: #f5f7fa;
>   --tab-selection-background-color: #4c9ed9;
>   --tab-selection-box-shadow: none;
>+%ifdef MOZ_PHOTON_THEME
>+  --pinned-tab-glow-url: url(chrome://browser/skin/tabbrowser/indicator-tab-attention.svg);

> .tabbrowser-tab:-moz-any([image], [pinned]) > .tab-stack > .tab-content[attention]:not([selected="true"]),
> .tabbrowser-tab > .tab-stack > .tab-content[pinned][titlechanged]:not([selected="true"]) {
>+%ifdef MOZ_PHOTON_THEME
>+  background-image: var(--pinned-tab-glow-url);
>+  background-position: center bottom -4px;

Please remove background-image and the --pinned-tab-glow-url variable since you're not changing the value from what you already set in tabs.inc.css.
Attachment #8882094 - Flags: review?(dao+bmo) → review+
(Assignee)

Comment 3

2 months ago
Created attachment 8882228 [details] [diff] [review]
Patch v.2

Updated for landing.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3af874360c71c0ed9d0dd01dd05de3cfa9171aed
Attachment #8882094 - Attachment is obsolete: true

Comment 4

2 months ago
Pushed by jdolske@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b8e1f6c6ebd6
Update pinned-tab highlight/glow style for Photon. r=dao

Comment 5

2 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b8e1f6c6ebd6
Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56

Updated

2 months ago
Iteration: --- → 56.2 - Jul 10
Sweet screenshots:

https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=a578ce873d805743283df9a3627372939d8c8b2c&newProject=mozilla-central&newRev=d536973fe668c6c6046fc3fda82e24f3379e3713&filter=fourPinned
(Assignee)

Updated

2 months ago
Depends on: 1379052

Comment 7

a month ago
(In reply to Justin Dolske [:Dolske] from comment #0)
> The Photon mocks show this as changing to a small blue dot.

This change introduced huge notification background for non-pinned tabs. Is it by purpose? 

See screenshot here: https://bug1383312.bmoattachments.org/attachment.cgi?id=8888959

Updated

a month ago
See Also: → bug 1383312
status-firefox57: affected → ---
Depends on: 1383449

Updated

16 days ago
No longer depends on: 1383449
QA Contact: brindusa.tot → ovidiu.boca
You need to log in before you can comment on or make changes to this bug.