Closed Bug 1376003 Opened 5 years ago Closed 5 years ago

Intermittent browser_ext_pageAction_telemetry.js | Data recorded for second extension for histogram: WEBEXT_PAGEACTION_POPUP_OPEN_MS. -

Categories

(WebExtensions :: General, defect, P3)

defect

Tracking

(firefox56 fixed)

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: bsilverberg)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

When writing a test for a new telemetry probe for browser.storage.local, I found my test was failing intermittently because I was checking the time in ms, rather than the count of telemetry recordings. It doesn't seem very likely that the timing in this test would be less than 1 ms, but I'm not sure what else might be causing the failure, so I have updated the test to check for counts instead of elapsed time.

If the test does fail in this case we will see more information about why it failed because I also converted some of the asserts from `ok` to `is`. I think it's worth landing this change which might fix the intermittent, and if not will at least give us a bit more information when it fails.
Assignee: nobody → bob.silverberg
Component: WebExtensions: Untriaged → WebExtensions: General
Priority: -- → P3
Comment on attachment 8881472 [details]
Bug 1376003 - Address intermittent browser_ext_pageAction_telemetry.js,

https://reviewboard.mozilla.org/r/152610/#review157778
Attachment #8881472 - Flags: review?(mixedpuppy) → review+
Pushed by bsilverberg@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/16784899765f
Address intermittent browser_ext_pageAction_telemetry.js, r=mixedpuppy
https://hg.mozilla.org/mozilla-central/rev/16784899765f
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.