1376050 - Date of birth field on orbitz.com travelers section doesn't accept valid input in Nightly

Status: VERIFIED FIXED

(Web Compatibility :: Site Reports, defect, P3)

Description

[Chris More [:cmore]]

Steps to reproduce:

1) Create an account on orbitz.com

2) Go to: https://www.orbitz.com/user/account

3) Click "other travelers"

4) Make up a name and try to enter a date into the birth date field.

5) Click save at the bottom.

Expected results:

Travler saved

Actual results:

Error saying "invalid date or format".

It is difficult to use the date picker to start let alone submit the form. No matter if I put in a valid date or not, I get the invalid date format error.

It works perfectly fine in Firefox 54.0 release or Chrome, but not in Fx 56.01a. When I got this error, I had to use another browser to book a flight.

Comment 1

[Chris More [:cmore]]

Attachment: Orbitz date picker for DOB for travler

Comment 2

[Chris More [:cmore]]

Attachment: DOB error

Comment 3

[:Gijs (he/him)]

Jessica, this sounds like it might be a regression caused by us implementing input type=date, can you investigate / forward to someone who can?

Comment 4

[Alice0775 White]

[Tracking Requested - why for this release]:

[Tracking Requested - why for this release]: Break web page

Regression window (with dom.forms.datetime;true):
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=3e6775cee4f7098f4d11bdd452c276a56ac1f29a&tochange=feaeb4c4a1149a7925e9d0e32a61fde7ad74b8f2

Regressed by Bug 1346085

Comment 5

[Jessica Jong [:jessica] (inactive)]

From the network monitor, I see the same form data sent to the server from Chrome and from Firefox Nightly, that is, for example:

{"first_name":"nj","middle_name":"","last_name":"kk","dob":"2017-06-01","primaryCountryCode":"1","phone_number":"","altCountryCode":"1","alt_phone_number":"","emergencyContactFirstName":"","emergencyContactLastName":"","engcyCountryCode":"1","emergencyContactPhoneNumber":"","alpha3PrimaryCountryCode":"usa","alpha3AltCountryCode":"usa","alpha3EngcyCountryCode":"usa"}

I wonder if the server is doing anything special when the UA is Firefox/Gecko, since I used "Edit and Resend" to change the UA part and then everything worked fine.

Is there a way to confirm this?

Comment 6

[Alice0775 White]

(In reply to Jessica Jong [:jessica] from comment #5)
> From the network monitor, I see the same form data sent to the server from
> Chrome and from Firefox Nightly, that is, for example:
> 
> {"first_name":"nj","middle_name":"","last_name":"kk","dob":"2017-06-01",
> "primaryCountryCode":"1","phone_number":"","altCountryCode":"1",
> "alt_phone_number":"","emergencyContactFirstName":"",
> "emergencyContactLastName":"","engcyCountryCode":"1",
> "emergencyContactPhoneNumber":"","alpha3PrimaryCountryCode":"usa",
> "alpha3AltCountryCode":"usa","alpha3EngcyCountryCode":"usa"}
> 
> I wonder if the server is doing anything special when the UA is
> Firefox/Gecko, since I used "Edit and Resend" to change the UA part and then
> everything worked fine.
> 
> Is there a way to confirm this?

I can confirm that UA spoofing fixis the problem, I.e., Setting "general.useragent.override" to "Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.104 Safari/537.36" also fix the problem.

So, it seems the site are doing different processing for each UA, and this is the site problem.

Tech evangelism?

Comment 7

[:Gijs (he/him)]

Karl, is this something you could help with? Do you know if we have contacts at Orbitz?

Comment 8

[Karl Dubost💡 :karlcow]

POST /users/189237532/addassociated HTTP/1.1
Host: www.orbitz.com
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:56.0) Gecko/20100101 Firefox/56.0
Accept: application/json, text/javascript, */*; q=0.01
Accept-Language: en-US,en;q=0.5
Accept-Encoding: gzip, deflate, br
Referer: https://www.orbitz.com/user/account
Content-Type: application/json
X-Requested-With: XMLHttpRequest
Content-Length: 370
Cookie: *** long cookie string ***
Connection: keep-alive

{"first_name":"Foo","middle_name":"","last_name":"Bar","dob":"2017-06-06","primaryCountryCode":"1","phone_number":"","altCountryCode":"1","alt_phone_number":"","emergencyContactFirstName":"","emergencyContactLastName":"","engcyCountryCode":"1","emergencyContactPhoneNumber":"","alpha3PrimaryCountryCode":"usa","alpha3AltCountryCode":"usa","alpha3EngcyCountryCode":"usa"}


{
  "exception": "Unable to parse date of birthjava.text.ParseException: Unparseable date: \"2017-06-06\"",
  "success": "0",
  "omnitureData": "{\"accountName\":\"10207aidepxe\",\"omnitureProperties\":{\"charSet\":\"UTF-8\",\"eVar56\":\"notRewardsMember\",\"server\":\"www.orbitz.com\",\"eVar55\":\"authenticated | full | EMAIL\",\"eVar54\":\"1033\",\"eVar18\":\"D\\u003dpageName\",\"eVar17\":\"D\\u003dpageName\",\"pageName\":\"page.Account.MyAccount\",\"list1\":\"11918.1|12520.0|99991.0\",\"activityId\":\"3a863a4e-00e0-4a0a-88e9-70a79ff32dce\",\"prop30\":\"1033\",\"prop11\":\"189237532\",\"prop10\":\"3a863a4e-00e0-4a0a-88e9-70a79ff32dce\",\"userType\":\"AUTHENTICATED\",\"prop13\":\"201442670\",\"prop12\":\"d65a0c18-f061-4d88-82e8-ec94480411d3\",\"eVar40\":\"NoPartnerTier\",\"prop14\":\"9a9e0042c34e72b4d3a49cce866c194139f11ca357003817d245a2fde885824d\"}}",
  "errorCode": "INVALID_DATE",
  "id": 189237532,
  "email": "mozwebqa@****.***"
}

Comment 9

[Karl Dubost💡 :karlcow]

so at least we know that their issue is happening at 
  "exception": "Unable to parse date of birthjava.text.ParseException: Unparseable date: \"2017-06-06\"",

Comment 10

[Karl Dubost💡 :karlcow]

I had a contact 4 years ago. I can try again.


Oh but wait… We are not sending the same thing than Safari.

* Safari/Chrome  "dob": "11/10/1985",
* Firefox        "dob": "2017-06-06",


So maybe there is something else before. We need to handle ;)

What the browser sent (Firefox) HTTP POST data:


{
  "first_name": "Foo",
  "middle_name": "",
  "last_name": "Bar",
  "dob": "2017-06-06",
  "primaryCountryCode": "1",
  "phone_number": "",
  "altCountryCode": "1",
  "alt_phone_number": "",
  "emergencyContactFirstName": "",
  "emergencyContactLastName": "",
  "engcyCountryCode": "1",
  "emergencyContactPhoneNumber": "",
  "alpha3PrimaryCountryCode": "usa",
  "alpha3AltCountryCode": "usa",
  "alpha3EngcyCountryCode": "usa"
}


What the browser sent (Safari) HTTP POST data:

{
  "first_name": "foo",
  "middle_name": "",
  "last_name": "bar",
  "dob": "11/10/1985",
  "primaryCountryCode": "1",
  "phone_number": "",
  "altCountryCode": "1",
  "alt_phone_number": "",
  "emergencyContactFirstName": "",
  "emergencyContactLastName": "",
  "engcyCountryCode": "1",
  "emergencyContactPhoneNumber": "",
  "alpha3PrimaryCountryCode": "usa",
  "alpha3AltCountryCode": "usa",
  "alpha3EngcyCountryCode": "usa"
}


When it's working the browser receives (Safari):

{
    "success": "1",
    "omnitureData": "{\"accountName\":\"10207aidepxe\",\"omnitureProperties\":{\"charSet\":\"UTF-8\",\"eVar56\":\"notRewardsMember\",\"server\":\"www.orbitz.com\",\"eVar55\":\"authenticated | full | EMAIL\",\"eVar54\":\"1033\",\"eVar18\":\"D\\u003dpageName\",\"eVar17\":\"D\\u003dpageName\",\"eVar28\":\"Account.Traveler.Add.Success\",\"pageName\":\"page.Account.AssociatedTravelers\",\"list1\":\"99991.0|11918.1|99991.0\",\"activityId\":\"49ca053d-eb7a-4b01-8dc0-7adaaa8f165d\",\"prop16\":\"Account.Traveler.Add.Success\",\"prop30\":\"1033\",\"prop11\":\"189237532\",\"prop10\":\"49ca053d-eb7a-4b01-8dc0-7adaaa8f165d\",\"userType\":\"AUTHENTICATED\",\"prop13\":\"201442670\",\"prop12\":\"30ca6335-d82e-47fd-9515-f5fa265aa9f0\",\"eVar40\":\"NoPartnerTier\",\"events\":\"event27\",\"prop14\":\"9a9e0042c34e72b4d3a49cce866c194139f11ca357003817d245a2fde885824d\"}}",
    "id": 189237532,
    "email": "mozwebqa@*******"
}

Comment 11

[Karl Dubost💡 :karlcow]

The markup associated.
<input id="assoDOB" name="dob" placeholder="mm/dd/yyyy" typebuffer="" type="date">
I also noticed that in nightly devtools. it display an empty event. Opening a bug for this.

Comment 12

[Jessica Jong [:jessica] (inactive)]

(In reply to Karl Dubost :karlcow from comment #10)
> I had a contact 4 years ago. I can try again.
> 
> 
> Oh but wait… We are not sending the same thing than Safari.
> 
> * Safari/Chrome  "dob": "11/10/1985",
> * Firefox        "dob": "2017-06-06",
> 

Safari doesn't support <input type=date>, so it's shown as a regular textbox with placeholder "mm/dd/yyyy". I think the server might be expecting the format "mm/dd/yyyy" from Firefox too, because we didn't support <input type=date>, until now. Now, we send the date in the same format as Chrome, that is, "yyyy-mm-dd", which is defined in the spec.

Comment 13

[Karl Dubost💡 :karlcow]

In Opera (Blink),


{
  "alpha3AltCountryCode": "usa",
  "alpha3EngcyCountryCode": "usa",
  "alpha3PrimaryCountryCode": "usa",
  "altCountryCode": "1",
  "alt_phone_number": "",
  "dob": "2015-06-17",
  "emergencyContactFirstName": "",
  "emergencyContactLastName": "",
  "emergencyContactPhoneNumber": "",
  "engcyCountryCode": "1",
  "first_name": "foo ",
  "last_name": "bar",
  "middle_name": "bar",
  "phone_number": "",
  "primaryCountryCode": "1"
}

so indeed server side user agent sniffing. I guess the best solution for them is to avoid server side UA sniffing and accept the two formats. 

I tried to renew an old contact, but the person left.
orbitz is part of expedia. I will dig for a contact.

Thanks.

Comment 14

[Gerry Chang [:gchang]]

Track 56+ as broken web page.

Comment 15

[Mike Taylor [:miketaylr]]

Karl, any luck on contacts?

Comment 16

[Karl Dubost💡 :karlcow]

There are two github repos for Expedia 
@ExpediaDotCom and @ExpediaInc
and Orbitz has on GitHub
@OrbitzWorldwide

Let's try with https://github.com/neuroshock

Contacted today

Comment 17

[Karl Dubost💡 :karlcow]

Trying another contact.
David Strugnell at Expedia.
https://twitter.com/struggyone
https://github.com/struggyone

Comment 18

[Liz Henry (:lizzard) (relman/hg->git project)]

I tried writing to a couple of people through LinkedIn contacts. 
Do we know it's still broken in 56/57?

Comment 19

[Chris More [:cmore]]

(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #18)
> I tried writing to a couple of people through LinkedIn contacts. 
> Do we know it's still broken in 56/57?

I just tested it in the latest nightly 57 and still doesn't work. I can now save the initial form, but it doesn't save anything and when I edit it and try to use the date picker, I get the same error as comment 0. So, in this case, I would have to use Chrome if this happened.

Comment 20

[Gerry Chang [:gchang]]

Mark 56 won't fix as we are only 1 week from RC.

Comment 21

[Mike Taylor [:miketaylr]]

Adam, do you think you might be able to find some contacts via LinkedIn for this one?

Comment 22

[Adam Stevenson [:adamopenweb]]

Sure, reaching out to Kevin Bess https://www.linkedin.com/in/krbess/.

Comment 23

[Liz Henry (:lizzard) (relman/hg->git project)]

Doesn't look like they are answering, marking this fix-optional for 57. 
I messaged another possible contact from Orbitz with a link to this bug.

Comment 24

[Liz Henry (:lizzard) (relman/hg->git project)]

I also reported the issue as "feedback" on both Expedia and Orbitz support sites with a link to the bug and a request that the feedback be passed on to a web dev or engineering team.

Comment 25

[Oana Arbuzov [:oanaarbuzov]]

I've created and account and signed in.

The layout seems to have changed, there is no "Date Picker" anymore, birth date can be manually added (by maintaining the format mm/dd/yyyy). Any valid date is accepted and stored in "Personal Info" section.

Note: there is no validation for invalid dates (e.g born in a future date).

Tested with:
Browser / Version: Firefox Nightly 61.0a1 (2018-04-19)
Operating System: Windows 10 Pro

Can you still reproduce it?

Comment 26

[Chris More [:cmore]]

(In reply to Oana Arbuzov [:oanaarbuzov] from comment #25)
> I've created and account and signed in.
> 
> The layout seems to have changed, there is no "Date Picker" anymore, birth
> date can be manually added (by maintaining the format mm/dd/yyyy). Any valid
> date is accepted and stored in "Personal Info" section.
> 
> Note: there is no validation for invalid dates (e.g born in a future date).
> 
> Tested with:
> Browser / Version: Firefox Nightly 61.0a1 (2018-04-19)
> Operating System: Windows 10 Pro
> 
> Can you still reproduce it?

I just tested it Fx59 release with my original instructions and all is fine now. No errors.