Closed Bug 1376091 Opened 5 years ago Closed 10 days ago
Alt+A fails to work as an access key on Linux, triggers cmd
_select All instead (change Alt+A to Ctrl+A for MOZ _WIDGET _GTK)
Bug 1376091 - For MOZ_WIDGET_GTK, change shortcut for `cmd_selectAll` from Alt+A to Ctrl+A. r=masayuki
48 bytes, text/x-phabricator-request
|Details | Review|
17.15 KB, patch
|Details | Diff | Splinter Review|
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:54.0) Gecko/20100101 Firefox/54.0 Build ID: 20170612121707 Steps to reproduce: In the Dutch version of Firefox, press Alt+D to put the cursor in the address bar and type a few letters. Then change your mind and press Alt+A. Actual results: All of the text in the address bar gets selected. Expected results: The Bookmarks menu should have opened -- in Dutch it is called "Bladwijzers", with the "a" underlined. This happens also when the cursor is in the search bar (next to the address bar) or in a text input field (like the one I am typing this into), but NOT when the "cursor" is somewhere in the regular text of a webpage. An equivalent problem has been reported for Swedish in bug 1308726. From other Dutch people I have heard this does not occur with the Windows version: there Alt+A always opens the Bookmarks menu, no matter where the cursor is. For some reason Firefox for Linux has Alt+A for "Select All" baked into it for some contexts. Others have wondered and complained about this before: see bug 239040#c1 and bug 279163#c7. Attached patch removes the Alt+A binding for "Select All" from the Linux version, leaving Ctrl+A to do "Select All" now everywhere. (I can make a Mercurial patch if you wish, if you tell me how to make a shallow checkout of the relevant component.) By the way: this is not a problem only with version 54.0 -- it has been a problem for at least seven years.
Hello, Benno, and thank you for working on this. Alt+A for selecting all is a relic from the program Emacs that has been causing trouble in the Linux version of Firefox for over ten years.
Hello Magnus. To be precise, the Alt+A is not a relic from Emacs. The Alt+A for "Select All" is an invention of the earliest Firefox/Netscape people, in order to allow Ctrl+A in text fields to work like it does on the Unix command line (and in several other terminal programs, like Emacs, joe, pico...). But thirteen years ago, Ctrl+A was made to do "Select All" by default everywhere in Firefox, and only when setting "KeyThemeName" to "Emacs" somewhere in the GTK configuration files would Ctrl+A in text fields again move to the beginning of line. But the Alt+A invention stuck around. It should be active only when the Emacs key theme is chosen, but... on Linux it is active always, getting in the way of some Dutch and Swedish people, and probably a few others as well.
OK, Benno, so Alt+A for "Select All" was created to have Ctrl+A continue to move the cursor to the beginning of the line. I knew about the Emacs settings in the GTK configuration files.
Benno, apart from a mercurial-styled patch, you also need to ask for review. I'm a bit unsure of whom to ask, but perhaps jet might know.
Status: UNCONFIRMED → NEW
Ever confirmed: true
I think the file you actually want to change is: dom/xbl/builtin/unix/platformHTMLBindings.xml
Component: Selection → Event Handling
(In reply to Jet Villegas (:jet) from comment #5) > I think the file you actually want to change is: > dom/xbl/builtin/unix/platformHTMLBindings.xml Is it lines 38 and 124 in http://searchfox.org/mozilla-central/source/dom/xbl/builtin/android/platformHTMLBindings.xml?
(In reply to Magnus Johansson from comment #6) > (In reply to Jet Villegas (:jet) from comment #5) > > I think the file you actually want to change is: > > dom/xbl/builtin/unix/platformHTMLBindings.xml > > Is it lines 38 and 124 in > http://searchfox.org/mozilla-central/source/dom/xbl/builtin/android/ > platformHTMLBindings.xml? Wrong link. It should have been http://searchfox.org/mozilla-central/source/dom/xbl/builtin/unix/platformHTMLBindings.xml See lines 14, 15, 26, 27, 69 and 79.
In Firefox version 52.2.0 the cursor doesn't even have to be in a text field for having Alt+A select all. When opening a Settings tab and there press Alt+A it, however, opens the menu Arkiv.
Component: Event Handling → User events and focus handling
Component: DOM: UI Events & Focus Handling → Keyboard Navigation
Product: Core → Firefox
Component: Keyboard Navigation → DOM: UI Events & Focus Handling
Product: Firefox → Core
Summary: Alt+A does "Select All" on Linux when cursor is in text field, instead of accessing a menu → Alt+A always does "Select All" on Linux, instead of accessing the relevant menu
Assignee: nobody → bugzilla2007
Status: NEW → ASSIGNED
Attachment #9250251 - Flags: feedback?(masayuki)
Severity: normal → S3
Summary: Alt+A always does "Select All" on Linux, instead of accessing the relevant menu → Alt+A fails to work as an access key on Linux, triggers cmd_selectAll instead (change Alt+A to Ctrl+A for MOZ_WIDGET_GTK)
Attachment #9250251 - Flags: feedback?(masayuki) → feedback+
Attachment #9250251 - Attachment is obsolete: true
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/853874dee29b For MOZ_WIDGET_GTK, change shortcut for `cmd_selectAll` from Alt+A to Ctrl+A. r=masayuki
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/31723 for changes under testing/web-platform/tests
Upstream PR merged by moz-wptsync-bot
You need to log in before you can comment on or make changes to this bug.