1376098 - [hamburger panel] Remove Page Setup menu item

Status: VERIFIED FIXED

(Firefox :: Menus, enhancement, P1)

Description

[Dão Gottwald [:dao]]

The Page Setup menu item lacks context; it's not clear that it has something to do with printing. Page Setup is also available with adequate context from the print preview (Print menu item). We should remove it as a top-level menu item.

Comment 1

[:Gijs (he/him)]

(In reply to Dão Gottwald [::dao] from comment #0)
> Page Setup is also available with adequate context from
> the print preview (Print menu item).

This is not the case on OS X.

Comment 2

[Dão Gottwald [:dao]]

On Mac, Page Setup is already in the native File menu where I guess most Mac users will look for it.

Comment 3

[:Gijs (he/him)]

Given this is specified in the design, forwarding this to Aaron/Bryan, but putting it in the reserve for now as I think we can ship with the state as-is (given that that is how it was designed...).

Comment 4

[Dão Gottwald [:dao]]

(In reply to :Gijs from comment #3)
> Given this is specified in the design, forwarding this to Aaron/Bryan, but
> putting it in the reserve for now as I think we can ship with the state
> as-is (given that that is how it was designed...).

It might be less confusing on Mac which I suspect the designers used. FWIW, I initially didn't understand what this item meant on Linux, and it seems pointless on Windows too. It's a bug in the design as far as I can tell, so "can ship as-is since it was designed this way" is somewhat nonsensical.

Comment 5

[Aaron Benson]

Yeah, we can remove the Page Setup item from the menu. On macOS those settings are available in the print dialog and are hidden under a Show/Hide Details button. Is there a way to open the print dialog with the details section open?

Comment 6

[:Gijs (he/him)]

(In reply to Aaron Benson from comment #5)
> Yeah, we can remove the Page Setup item from the menu. On macOS those
> settings are available in the print dialog and are hidden under a Show/Hide
> Details button. Is there a way to open the print dialog with the details
> section open?

I doubt it, it's an OS-provided native dialog, I think, and it remembers the last pane you had open. Certainly not without some cocoa work, plus that would be a change from the File menu and other native mac apps like Pages or TextEdit.

Given this, would you want the entry removed completely, or simply keep it on OS X and remove it on Windows/Linux, to match the File menu?

Comment 7

[Aaron Benson]

We can remove it for all platforms.

Comment 8

[:Gijs (he/him)]

Attachment: Bug 1376098 - remove page setup item from hamburger panel,

Review commit: https://reviewboard.mozilla.org/r/153700/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/153700/

Comment 9

[Dão Gottwald [:dao]]

Comment on attachment 8882613 [details]
Bug 1376098 - remove page setup item from hamburger panel,

https://reviewboard.mozilla.org/r/153700/#review158862

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/02ebf3b5e215
remove page setup item from hamburger panel, r=dao

Comment 11

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/02ebf3b5e215

Comment 12

[u554753]

Verified on Windows, Mac, and Ubuntu.