[hamburger panel] Remove Page Setup menu item

VERIFIED FIXED in Firefox 56

Status

()

Firefox
Menus
P1
normal
VERIFIED FIXED
2 months ago
20 days ago

People

(Reporter: dao, Assigned: Gijs)

Tracking

(Blocks: 2 bugs)

Trunk
Firefox 56
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 verified)

Details

(Whiteboard: [photon-structure])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

2 months ago
The Page Setup menu item lacks context; it's not clear that it has something to do with printing. Page Setup is also available with adequate context from the print preview (Print menu item). We should remove it as a top-level menu item.
(Assignee)

Comment 1

2 months ago
(In reply to Dão Gottwald [::dao] from comment #0)
> Page Setup is also available with adequate context from
> the print preview (Print menu item).

This is not the case on OS X.
(Reporter)

Comment 2

2 months ago
On Mac, Page Setup is already in the native File menu where I guess most Mac users will look for it.
(Assignee)

Comment 3

2 months ago
Given this is specified in the design, forwarding this to Aaron/Bryan, but putting it in the reserve for now as I think we can ship with the state as-is (given that that is how it was designed...).
Flags: needinfo?(bbell)
Flags: needinfo?(abenson)
Whiteboard: [photon-structure][triage] → [reserve-photon-structure]

Updated

2 months ago
Flags: qe-verify?
Priority: -- → P3
(Assignee)

Updated

2 months ago
Flags: qe-verify? → qe-verify+

Updated

2 months ago
QA Contact: gwimberly
(Reporter)

Comment 4

2 months ago
(In reply to :Gijs from comment #3)
> Given this is specified in the design, forwarding this to Aaron/Bryan, but
> putting it in the reserve for now as I think we can ship with the state
> as-is (given that that is how it was designed...).

It might be less confusing on Mac which I suspect the designers used. FWIW, I initially didn't understand what this item meant on Linux, and it seems pointless on Windows too. It's a bug in the design as far as I can tell, so "can ship as-is since it was designed this way" is somewhat nonsensical.

Comment 5

2 months ago
Yeah, we can remove the Page Setup item from the menu. On macOS those settings are available in the print dialog and are hidden under a Show/Hide Details button. Is there a way to open the print dialog with the details section open?
Flags: needinfo?(bbell)
Flags: needinfo?(abenson)
(Assignee)

Comment 6

2 months ago
(In reply to Aaron Benson from comment #5)
> Yeah, we can remove the Page Setup item from the menu. On macOS those
> settings are available in the print dialog and are hidden under a Show/Hide
> Details button. Is there a way to open the print dialog with the details
> section open?

I doubt it, it's an OS-provided native dialog, I think, and it remembers the last pane you had open. Certainly not without some cocoa work, plus that would be a change from the File menu and other native mac apps like Pages or TextEdit.

Given this, would you want the entry removed completely, or simply keep it on OS X and remove it on Windows/Linux, to match the File menu?
Flags: needinfo?(abenson)

Comment 7

2 months ago
We can remove it for all platforms.
Flags: needinfo?(abenson)
(Assignee)

Updated

2 months ago
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Iteration: --- → 56.2 - Jul 10
Priority: P3 → P1
Whiteboard: [reserve-photon-structure] → [photon-structure]
Comment hidden (mozreview-request)
(Reporter)

Comment 9

2 months ago
mozreview-review
Comment on attachment 8882613 [details]
Bug 1376098 - remove page setup item from hamburger panel,

https://reviewboard.mozilla.org/r/153700/#review158862
Attachment #8882613 - Flags: review?(dao+bmo) → review+

Comment 10

2 months ago
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/02ebf3b5e215
remove page setup item from hamburger panel, r=dao

Comment 11

2 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/02ebf3b5e215
Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Verified on Windows, Mac, and Ubuntu.
Status: RESOLVED → VERIFIED
status-firefox56: fixed → verified
Flags: qe-verify+
Blocks: 1387512
You need to log in before you can comment on or make changes to this bug.