Sidebar header has a dark background and dark text with the dark compact theme

VERIFIED FIXED in Firefox 56

Status

()

P1
normal
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: dao, Assigned: dao)

Tracking

({regression})

Trunk
Firefox 56
regression
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox54 unaffected, firefox55 unaffected, firefox56 fixed)

Details

(Whiteboard: [photon-visual])

Attachments

(2 attachments)

(Assignee)

Description

2 years ago
+++ This bug was initially created as a clone of Bug #1365705 +++

Bug 1367242 likely regressed this.
Iteration: --- → 56.1 - Jun 26
Flags: qe-verify+
QA Contact: brindusa.tot
Iteration: 56.1 - Jun 26 → 56.2 - Jul 10

Comment 2

2 years ago
mozreview-review
Comment on attachment 8881048 [details]
Bug 1376109 - Consolidate default sidebarheader styling and don't remove its background for lightweight themes.

https://reviewboard.mozilla.org/r/152392/#review158080
Attachment #8881048 - Flags: review?(nhnt11) → review+

Comment 3

2 years ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/33e589452ed3
Consolidate default sidebarheader styling and don't remove its background for lightweight themes. r=nhnt11
No longer blocks: 1377003

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/33e589452ed3
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox56: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Depends on: 1377185

Comment 5

2 years ago
I have reproduced this bug with Nightly 56.0a1 (2017-06-24) on Windows 8.1 (64 bit).

This bug's fix is verified on Latest Nightly 56.0a1.

Build ID : 20170703030203
User Agent : Mozilla/5.0 (Windows NT 6.3; WOW64; rv:56.0) Gecko/20100101 Firefox/56.0
QA Whiteboard: [bugday-20170628]
status-firefox54: --- → unaffected
status-firefox-esr52: --- → unaffected

Updated

2 years ago
Depends on: 1390410
(Assignee)

Updated

2 years ago
No longer depends on: 1390410
QA Contact: brindusa.tot → ovidiu.boca
I tested this on Mac and Windows 10 with Nightly 57.0a1(2017-08-21) and I don't have the expected result that is presented in spec. http://design.firefox.com/people/shorlander/photon/Mockups/windows-10.html and http://design.firefox.com/people/shorlander/photon/Mockups/macOS.html

The attached file is a print screen from Mac Os X 10.10 with the dark theme.
Flags: needinfo?(dao+bmo)
(Assignee)

Comment 7

2 years ago
(In reply to ovidiu boca[:Ovidiu] from comment #6)
> Created attachment 8899471 [details]
> Screen Shot 2017-08-21 at 5.11.33 PM.png
> 
> I tested this on Mac and Windows 10 with Nightly 57.0a1(2017-08-21) and I
> don't have the expected result that is presented in spec.
> http://design.firefox.com/people/shorlander/photon/Mockups/windows-10.html
> and http://design.firefox.com/people/shorlander/photon/Mockups/macOS.html

That's bug 1385518.

This bug is merely about the sidebar header being readable.
Flags: needinfo?(dao+bmo)
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.