AXRoleDescription for ARIA heading role should be "heading" not "AXHeading"

RESOLVED FIXED in Firefox 56

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jdiggs, Assigned: jdiggs)

Tracking

unspecified
mozilla56
Unspecified
macOS
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

2 years ago
As per the Core AAM [1], the value of AXRoleDescription for the heading role should be "heading". But Gecko is exposing "AXHeading".

[1] https://rawgit.com/w3c/aria/master/core-aam/core-aam.html#role-map-heading
(Assignee)

Comment 1

2 years ago
Posted patch proposed patch (obsolete) — Splinter Review
Assignee: nobody → jdiggs
Status: NEW → ASSIGNED
Attachment #8881060 - Flags: review?(mzehe)
Comment on attachment 8881060 [details] [diff] [review]
proposed patch

Is there a list somewhere what the localized strings should be for this, or are they free form? If there is a source, please add a comment above the localized string to indicate this. Thanks! r=me.
Attachment #8881060 - Flags: review?(mzehe) → review+
(Assignee)

Comment 3

2 years ago
(In reply to Marco Zehe (:MarcoZ) from comment #2)
> Comment on attachment 8881060 [details] [diff] [review]
> proposed patch
> 
> Is there a list somewhere what the localized strings should be for this, or
> are they free form? If there is a source, please add a comment above the
> localized string to indicate this. Thanks! r=me.

Done. Thanks!
Attachment #8881060 - Attachment is obsolete: true
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 4

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a7effdfd856a
Fix AXRoleDescription for ARIA heading role. r=MarcoZ
Keywords: checkin-needed

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a7effdfd856a
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.