Closed Bug 1376126 Opened 3 years ago Closed 3 years ago

CycleCollectedJSRuntime::RemoveJSHolder does unnecessary hashtable lookups

Categories

(Core :: XPCOM, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: mats, Assigned: mats)

References

Details

(Keywords: perf, Whiteboard: [qf])

Attachments

(1 file)

No description provided.
Comment on attachment 8881064 [details] [diff] [review]
Use Lookup() entry instead of Get+Remove in CycleCollectedJSRuntime::RemoveJSHolder to avoid unnecessary hashtable lookups

Review of attachment 8881064 [details] [diff] [review]:
-----------------------------------------------------------------

For avoidance of doubt: please wait for mccr8's feedback before landing.  Thanks!
Attachment #8881064 - Flags: review?(nfroyd) → review+
Attachment #8881064 - Flags: feedback?(continuation) → feedback+
Pushed by mpalmgren@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4692d0721273
Use Lookup() entry instead of Get+Remove in CycleCollectedJSRuntime::RemoveJSHolder to avoid unnecessary hashtable lookups.  r=froydnj
https://hg.mozilla.org/mozilla-central/rev/4692d0721273
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.