shistory.accesskey used instead of shistoryDescription2.accesskey




16 years ago
16 years ago


(Reporter: Jaagup Irve, Assigned: dbragg)



Firefox Tracking Flags

(Not tracked)




16 years ago
Mozilla/5.0 (Windows; U; Win98; et-EE; rv:0.9.9+) Gecko/20020410

in prefs-history.dtd there is a shortcut key named shistory.accesskey, which is
used on label named shistoryDescription2.label in the xul.

shistory.accesskey should be renamed to shistoryDescription2.accesskey and the
corresponding XUL file needs updating.

localization tools are currently associating the accesskey with wrong label.

Comment 1

16 years ago
over to ftang
Assignee: yokoyama → ftang

Comment 2

16 years ago
why this is a bug. I think this is invalid. Is there any documentation suggest
the relationship between the naming of a label and an accesskey?
over to tao to make decision. I think this bug is invalid. 
Assignee: ftang → tao

Comment 3

16 years ago
Don - would you pleae take a look? Seems to me the developer should use match
the entity names with their usage.
Assignee: tao → dbragg

Comment 4

16 years ago
What "localization tools" are you refering to?

Comment 5

16 years ago
MozillaTranslator, but I think it will affect anyone using a tool that 
can associate labels and accesskeys by their name prefixes.

Otherwise localizers must go digging XUL files (or DOM inspector, I presume) to 
find out where that particurlar label gets its accesskey from.

Apart from being a way for programs to group labels, accesskeys and command 
keys, it is also an elegant solution.

Comment 6

16 years ago
I agree with you.  It is good practice to make the accesskey prefix match the
label prefix with which it is associated.  I'm just not sure we can depend on it
happening across the product so that a translation tool can be based on it.

Comment 7

16 years ago
Of course, 100% consistency is hard to get, but in this case, the accesskey is 
associated with totally irrelevant label.


16 years ago
QA Contact: ruixu → ylong

Comment 8

16 years ago
Searching lxr and looking in pref-history.xul|dtd i can't find either of the 
entities you refer to so i'm presuming this has disappeared. Marking INVALID.
Last Resolved: 16 years ago
Resolution: --- → INVALID

Comment 9

16 years ago
Mark as verified per previous comment.
You need to log in before you can comment on or make changes to this bug.