Turn nsDocumentViewer::mHintCharset and mForceCharacterSet into const mozilla::Encoding*

RESOLVED FIXED in Firefox 56

Status

()

Core
Internationalization
RESOLVED FIXED
11 months ago
11 months ago

People

(Reporter: emk, Unassigned)

Tracking

unspecified
mozilla56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Comment hidden (empty)
Comment hidden (mozreview-request)
(Reporter)

Comment 2

11 months ago
This patch will also fix a bug of TryHintCharset that bug 1373984 introduced. GetHintCharacterSet will never fail but it can return an empty string. If it returns an empty string, it will crash.
Comment hidden (mozreview-request)
(Reporter)

Comment 4

11 months ago
(In reply to Masatoshi Kimura [:emk] from comment #2)
> This patch will also fix a bug of TryHintCharset that bug 1373984
> introduced. GetHintCharacterSet will never fail but it can return an empty
> string. If it returns an empty string, it will crash.

I piggybacked this on the bustage fix.

Comment 5

11 months ago
mozreview-review
Comment on attachment 8881109 [details]
Bug 1376164 - Turn nsDocumentViewer::mHintCharset and mForceCharacterSet into const mozilla::Encoding*.

https://reviewboard.mozilla.org/r/152418/#review157502

Thank you.
Attachment #8881109 - Flags: review?(hsivonen) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 8

11 months ago
Pushed by VYV03354@nifty.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/5554fd16af9b
Turn nsDocumentViewer::mHintCharset and mForceCharacterSet into const mozilla::Encoding*. r=hsivonen

Comment 9

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/5554fd16af9b
Status: NEW → RESOLVED
Last Resolved: 11 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.