1376164 - Turn nsDocumentViewer::mHintCharset and mForceCharacterSet into const mozilla::Encoding*

Status: RESOLVED FIXED

(Core :: Internationalization, enhancement)

Comment 1

[Masatoshi Kimura [:emk]]

Attachment: Bug 1376164 - Turn nsDocumentViewer::mHintCharset and mForceCharacterSet into const mozilla::Encoding*.

Review commit: https://reviewboard.mozilla.org/r/152418/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/152418/

Comment 2

[Masatoshi Kimura [:emk]]

This patch will also fix a bug of TryHintCharset that bug 1373984 introduced. GetHintCharacterSet will never fail but it can return an empty string. If it returns an empty string, it will crash.

Comment 3

[Masatoshi Kimura [:emk]]

Comment on attachment 8881109 [details]
Bug 1376164 - Turn nsDocumentViewer::mHintCharset and mForceCharacterSet into const mozilla::Encoding*.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/152418/diff/1-2/

Comment 4

[Masatoshi Kimura [:emk]]

(In reply to Masatoshi Kimura [:emk] from comment #2)
> This patch will also fix a bug of TryHintCharset that bug 1373984
> introduced. GetHintCharacterSet will never fail but it can return an empty
> string. If it returns an empty string, it will crash.

I piggybacked this on the bustage fix.

Comment 5

[Henri Sivonen (:hsivonen)]

Comment on attachment 8881109 [details]
Bug 1376164 - Turn nsDocumentViewer::mHintCharset and mForceCharacterSet into const mozilla::Encoding*.

https://reviewboard.mozilla.org/r/152418/#review157502

Thank you.

Comment 6

[Masatoshi Kimura [:emk]]

Comment on attachment 8881109 [details]
Bug 1376164 - Turn nsDocumentViewer::mHintCharset and mForceCharacterSet into const mozilla::Encoding*.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/152418/diff/2-3/

Comment 7

[Masatoshi Kimura [:emk]]

Comment on attachment 8881109 [details]
Bug 1376164 - Turn nsDocumentViewer::mHintCharset and mForceCharacterSet into const mozilla::Encoding*.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/152418/diff/3-4/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5554fd16af9b
Turn nsDocumentViewer::mHintCharset and mForceCharacterSet into const mozilla::Encoding*. r=hsivonen

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5554fd16af9b