Closed Bug 1376215 Opened 3 years ago Closed 3 years ago

Don't expose WrClipRegionToken from WebRenderAPI.h

Categories

(Core :: Graphics: WebRender, enhancement, P3)

Other Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: kats, Assigned: kats)

References

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

In servo/webrender#1412, Martin removed the per-item complex clip stuff. As a result, we need to update all the call sites on the gecko side to just pass in a rect instead of obtaining and passing in a WrClipRegionToken.

This is a pretty mechanical change but touches a number of files, so I'd like to land part of it ahead of time. Otherwise I need to keep manually rebasing this patch until we finally land the WR update, which is going to be annoying.
Comment on attachment 8881157 [details]
Bug 1376215 - Stop exposing the WrClipRegionToken in WebRenderAPI.h APIs.

https://reviewboard.mozilla.org/r/152428/#review157524
Attachment #8881157 - Flags: review?(jmuizelaar) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/504e5b1de987
Stop exposing the WrClipRegionToken in WebRenderAPI.h APIs. r=jrmuizel
backed out for bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=109855344&repo=autoland , sorry kats!
Flags: needinfo?(bugmail)
Backout by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/78faa3c67fc3
Backed out changeset 504e5b1de987 for bustage
Ah, it collided with bug 1368846 which wasn't on central yet. Will rebase and reland.
Flags: needinfo?(bugmail)
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/51589258196e
Stop exposing the WrClipRegionToken in WebRenderAPI.h APIs. r=jrmuizel
https://hg.mozilla.org/mozilla-central/rev/51589258196e
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.