1376243 - glterrain causes a device reset when Advanced Layers is enabled

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[David Anderson [:dvander] - inactive, e-mail if emergency]

This test has a history of being a bit flaky, and is currently a bit flaky on Windows 10. But with AL it quite reliably has a new failure mode of what might be a driver reset, and manifests in shaders not compiling with E_OUTOFMEMORY. Example try run:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=32a3c9496ff2af8f5a9b5cf451dd46ed3dca4d2a

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

I can reproduce this on my Win8 loaner. Looks like OpenSharedHandle is returning E_OUTOFMEMORY so we force a device reset.

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: bug1376243.patch

The bug is that AL was not flushing unused TextureHosts, so WebGL was allocating more until the compositor process ran out of memory (either in D3D11 or jemalloc, whichever came first).

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/37208b6123a1
Fix not flushing unused TextureHosts in Advanced Layers. (bug 1376243, r=mattwoodrow)

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/37208b6123a1