Closed Bug 1376275 Opened 4 years ago Closed 3 years ago

[Launchpad] The "show all options" button from the Netmonitor details panel is not working

Categories

(DevTools :: Netmonitor, defect, P3)

Product:
DevTools
Component:
Netmonitor
Version:
55 Branch
Type:
defect

Tracking

(firefox56 affected, firefox57 fix-optional)

Status:
RESOLVED WONTFIX
Tracking Flags:
Tracking Status
firefox56 --- affected
firefox57 --- fix-optional

People

(Reporter: emilghitta, Assigned: akriti.v10, Mentored)

References

Details

(Whiteboard: good-first-bug)

Attachments

(7 files, 4 obsolete files)

Netmonitor Show all button.gif
3.53 MB, image/gif
Details
Show all buttons 2.gif
2.14 MB, image/gif
Details
bug 1376275 : The 'show all options' button from the netmonitor details panel is now working , r = Honza
59 bytes, text/x-review-board-request
Details
menu.png
14.19 KB, image/png
Details
Backed out changeset 6c79ad7b763b
59 bytes, text/x-review-board-request
Details
Bug 1376275 : The 'show all options' button from the netmonitor details panel is now working, r:Honza
59 bytes, text/x-review-board-request
Honza
: review-
Details
show-all-options.png
686.21 KB, image/png
Details 
[Launchpad] The "show all options" button from the Netmonitor details panel is not working.

[Affected versions]:
Firefox 56.0a1 (Build Id:20170625030210)

[Affected platforms]:
Windows 10 64bit
Mac 10.11.6
Ubuntu 16.04 64bit


[Steps to reproduce]:
1.Launch Firefox.
2.Open Netmonitor via launchpad.
3.Access the https://en.wikipedia.org/wiki/Main_Page webpage via Launchpad.
4.Click on any request.
5.Shrink the request details panel.
6.Click on the button to display all options.


[Expected result]:
All available options are displayed in the dropdown menu.

[Actual result]:
The button is not working.

[Regression range]:
This is reproducible using Launchpad 0.0.75 (also reproducible with 0.0.67).
I don't think that this is a regression.

[Additional Information]
This issue is not reproducible with Netmonitor opened from DevTools.
I can reproduce that problem. 

Thanks for the report!

Honza
Priority: -- → P3
The problem here is that the popup menu (with available options/side bar tabs) is displayed at wrong location and not fully visible on the screen (it's hidden behind right border of the browser window)

Here is where the location coordinates are calculated:
http://searchfox.org/mozilla-central/rev/17ebac68112bd635b458e831670c1e506ebc17ad/devtools/client/shared/components/tabs/tabbar.js#196

Note that you need to test in the Launchpad (this works fine in the Toolbox)

Read this post to see how to load the Netmonitor panel in the Launchpad:
https://hacks.mozilla.org/2017/06/hacking-on-the-network-monitor-developer-tool/
(watch the video tutorial at the end of the post)

Honza
Mentor: odvarko
Whiteboard: good-first-bug
Attached image Show all buttons 2.gif — 
Hi Honza!

It seems that on version 0.0.88 the behavior of the "show all options" dropdown menu has changed:

-The current behavior is that the dropdown menu is opened in an incorrect position (top left corner).
-The options displayed in the dropdown menu are not working.
-The dropdown menu can't be dismissed. 

I believe that due to the fact that the dropdown menu can't be dismissed, the ceckboxes dropdown menu (opened by right clicking on the column) and the context menu (opened by right clicking on any request) can't be opened.

I think that this is a regression from version 0.0.75 caused by the fix that was made in bug 1376291.

I attached a screencast for this new behavior.

Thanks!
Flags: needinfo?(odvarko)
(In reply to Emil Ghitta, QA [:emilghitta] from comment #3)
> -The current behavior is that the dropdown menu is opened in an incorrect
> position (top left corner).
> -The options displayed in the dropdown menu are not working.
> -The dropdown menu can't be dismissed. 
Thanks for the comment Emil!

Yes, I am also seeing the same and new behavior.

> I think that this is a regression from version 0.0.75 caused by the fix that
> was made in bug 1376291.
There is also a follow up bug that could cause this issue: bug 1380927

Honza
Flags: needinfo?(odvarko)
Hi is this bug resolved. If not then i would like to work on this bug.
(In reply to akriti verma from comment #5)
> Hi is this bug resolved. If not then i would like to work on this bug.

Excellent, assigned to you!

Honza
Assignee: nobody → akriti.v10
Hi, Thanks for assigning me this task . Currently i am setting up the development environment .Once it's set up, i'll start the actual work.
Hi Jan , I'm executing the 'yarn start' command but i am constantly getting the following error:

  "ERROR in ../shared/file-saver.js
Module build failed: ReferenceError: Unknown plugin "transform-flow-strip-types" specified in "base" at 0, attempted to resolve relative to "/home/ruby/src/mozilla-central/devtools/client/shared"

I have tried many solutions from 'npm re-installation' to manually adding "babel-core-transform-flow-strip-types" in script.js , but none of them have worked. Can you suggest me a solution for this error?
Hi, I have uploaded a patch.
In this patch i have removed the "rect.left" and "rect.bottom" variables. This has caused the popup menu (with available options/side bar tabs) to reappear.
(In reply to akriti verma from comment #8)
> Hi Jan , I'm executing the 'yarn start' command but i am constantly getting
> the following error:
> 
>   "ERROR in ../shared/file-saver.js
> Module build failed: ReferenceError: Unknown plugin
> "transform-flow-strip-types" specified in "base" at 0, attempted to resolve
> relative to "/home/ruby/src/mozilla-central/devtools/client/shared"

I am not seeing this error. After running `yarn start` here is the output:

$ yarn start
yarn start v0.22.0
$ node bin/dev-server
Listening for WS on *:9000. Will proxy to TCP on *:6080 on first WS connection
Protocol messages can be logged by enabling logging.firefoxProtocol in your loca
l.json config
Hot Reloading - https://github.com/devtools-html/debugger.html/blob/master/docs/
local-development.md#hot-reloading
Development Server Listening at http://localhost:8000
WS connection closed, disconnected from TCP

> I have tried many solutions from 'npm re-installation' to manually adding
> "babel-core-transform-flow-strip-types" in script.js , but none of them have
> worked. Can you suggest me a solution for this error?
What's your NPM and node version?

Main:
- node 8.4.0
- npm 5.4.2

Honza
(In reply to akriti verma from comment #10)
> Hi, I have uploaded a patch.
> In this patch i have removed the "rect.left" and "rect.bottom" variables.
> This has caused the popup menu (with available options/side bar tabs) to
> reappear.

I can see the menu now, but it's at wrong position.

Honza
(In reply to Jan Honza Odvarko [:Honza] from comment #12)
> (In reply to akriti verma from comment #10)
> > Hi, I have uploaded a patch.
> > In this patch i have removed the "rect.left" and "rect.bottom" variables.
> > This has caused the popup menu (with available options/side bar tabs) to
> > reappear.
> 
> I can see the menu now, but it's at wrong position.
> 
> Honza

what should be the position?
(In reply to Jan Honza Odvarko [:Honza] from comment #12)
> (In reply to akriti verma from comment #10)
> > Hi, I have uploaded a patch.
> > In this patch i have removed the "rect.left" and "rect.bottom" variables.
> > This has caused the popup menu (with available options/side bar tabs) to
> > reappear.
> 
> I can see the menu now, but it's at wrong position.
> 
> Honza

What should be the correct position for the popup menu?

Akriti
Attached image menu.png — 
(In reply to akriti verma from comment #14)
> What should be the correct position for the popup menu?
See the attached screenshot.

This is how it works in the Toolbox. The menu should be displayed underneath of the button.

Honza
@akrity: btw. as soon as the patch is ready, don't forget to ask for review.
(otherwise I am not notified by the review board)

Honza
(In reply to Jan Honza Odvarko [:Honza] from comment #18)
> @akrity: btw. as soon as the patch is ready, don't forget to ask for review.
> (otherwise I am not notified by the review board)
> 
> Honza

I'm sorry i missed the review part. I'll submit another patch and ask for the review.
Thanks
Comment on attachment 8915103 [details]
Bug 1376275 : The 'show all options' button from the netmonitor details panel is now working at the specified position,

https://reviewboard.mozilla.org/r/186366/#review191802

Still no luck. The menu is at wrong position and these changes breaks the location of the menu in the Toolbox. Are you testing that scenario too?

Btw. where did you get the 50 and 100 values?

Also, how do you generate the patches? I have some troubles to apply them and also the review-board isn't properly updated. Are you editing it manually?

Honza
Attachment #8915103 - Flags: review?(odvarko) → review-
(In reply to Jan Honza Odvarko [:Honza] from comment #22)
> Comment on attachment 8915103 [details]
> Bug 1376275 : The 'show all options' button from the netmonitor details
> panel is now working at the specified position,
> 
> https://reviewboard.mozilla.org/r/186366/#review191802
> 
> Still no luck. The menu is at wrong position and these changes breaks the
> location of the menu in the Toolbox. Are you testing that scenario too?
> 
> Btw. where did you get the 50 and 100 values?
> 
> Also, how do you generate the patches? I have some troubles to apply them
> and also the review-board isn't properly updated. Are you editing it
> manually?
> 
> Honza

Hi Honza ,
Sorry for a late reply. I have removed the constants. As per my current changes , i get the specified position for the menu , but i just want to verify the output before i submit a patch. So can you please replace the following line 
  

"menu.popup(rect.left + screenX, rect.bottom + screenY,{ doc: this.props.menuDocument });"

in your devtools/client/shared/components/tabs/tabbar.js with

"menu.popup(rect.left - (8 * rect.width), rect.bottom, { doc: this.props.menuDocument });"   and attach a screenshot of the output you get.

Thanks!
Akriti
Attachment #8915030 - Attachment is obsolete: true
Attachment #8915031 - Attachment is obsolete: true
Attachment #8915102 - Attachment is obsolete: true
Attachment #8915103 - Attachment is obsolete: true
Comment on attachment 8925488 [details]
Bug 1376275 : The 'show all options' button from the netmonitor details panel is now working, r:Honza

Hi Honza ,
Sorry for a late reply. I have removed the constants. As per my current changes , i get the specified position for the menu , but i just want to verify the output before i submit a patch. So can you please replace the following line 
  

"menu.popup(rect.left + screenX, rect.bottom + screenY,{ doc: this.props.menuDocument });"

in your devtools/client/shared/components/tabs/tabbar.js with

"menu.popup(rect.left - (8 * rect.width), rect.bottom, { doc: this.props.menuDocument });"   and attach a screenshot of the output you get.

Thanks!
Flags: needinfo?(odvarko)
Attachment #8925488 - Flags: review?(odvarko)
Attached image show-all-options.png — 
Position of the menu is correct when using it from within the Launchpad, but it's wrong when opening the menu from DevTools Toolbox. See the attached screenshot.

Honza
Flags: needinfo?(odvarko)
Comment on attachment 8925488 [details]
Bug 1376275 : The 'show all options' button from the netmonitor details panel is now working, r:Honza

https://reviewboard.mozilla.org/r/196620/#review224474
Attachment #8925488 - Flags: review?(odvarko) → review-
Product: Firefox → DevTools
Support for the Launchpad is discontinued. Closing.

Honza
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.