ContentParent does unnecessary hashtable lookups

RESOLVED FIXED in Firefox 56

Status

()

Core
IPC
P3
normal
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: mats, Assigned: mats)

Tracking

({perf})

Trunk
mozilla56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(2 attachments)

Comment hidden (empty)
(Assignee)

Comment 1

4 months ago
Created attachment 8881250 [details] [diff] [review]
part 1 - Remove an unnecessary GetWeak call before Remove, and use Lookup instead of GetWeak+Remove, to avoid unnecessary hashtable lookups
Attachment #8881250 - Flags: review?(nfroyd)
(Assignee)

Comment 2

4 months ago
Created attachment 8881251 [details] [diff] [review]
part 2 - Use Lookup instead of Get+Remove, to avoid unnecessary hashtable lookups
Attachment #8881251 - Flags: review?(nfroyd)

Updated

4 months ago
Attachment #8881250 - Flags: review?(nfroyd) → review+

Updated

4 months ago
Attachment #8881251 - Flags: review?(nfroyd) → review+

Comment 3

4 months ago
Pushed by mpalmgren@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/99cdce3d06f0
part 1 - Remove an unnecessary GetWeak call before Remove, and use Lookup instead of GetWeak+Remove, to avoid unnecessary hashtable lookups.  r=froydnj
https://hg.mozilla.org/integration/mozilla-inbound/rev/5d7f9d97d90e
part 2 - Use Lookup instead of Get+Remove, to avoid unnecessary hashtable lookups.  r=froydnj

Comment 4

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/99cdce3d06f0
https://hg.mozilla.org/mozilla-central/rev/5d7f9d97d90e
Status: NEW → RESOLVED
Last Resolved: 4 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.