1376297 - ImageBridgeChild does unnecessary hashtable lookups

Status: RESOLVED FIXED

(Core :: Graphics: Layers, enhancement, P3)

Comment 1

[Mats Palmgren (inactive)]

Attachment: part 1 - Use Lookup instead of Get+Remove, and remove a useless Get before Remove, to avoid unnecessary hashtable lookups

Comment 2

[Mats Palmgren (inactive)]

Attachment: part 2 - Switch to nsRefPtrHashtable since it's more appropriate for holding RefPtr values

Comment 3

[Nathan Froyd [:froydnj]]

Comment on attachment 8881255 [details] [diff] [review]
part 2 - Switch to nsRefPtrHashtable since it's more appropriate for holding RefPtr values

Review of attachment 8881255 [details] [diff] [review]:
-----------------------------------------------------------------

I feel like I am reviewing the exact same code here that I reviewed in CompositorBridgeChild...

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/92f807c93f8d
part 1 - Use Lookup instead of Get+Remove, and remove a useless Get before Remove, to avoid unnecessary hashtable lookups.  r=froydnj
https://hg.mozilla.org/integration/mozilla-inbound/rev/b03666e4837e
part 2 - Switch to nsRefPtrHashtable since it's more appropriate for holding RefPtr values.  r=froydnj

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/92f807c93f8d
https://hg.mozilla.org/mozilla-central/rev/b03666e4837e