Expose the value of aria-orientation via NSAccessibilityOrientationAttribute

RESOLVED FIXED in Firefox 56

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jdiggs, Assigned: jdiggs)

Tracking

unspecified
mozilla56
Unspecified
macOS
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

2 years ago
Gecko doesn't expose the value of aria-orientation on macOS. (This support is already in place for ATK and IA2.)
(Assignee)

Comment 1

2 years ago
Posted patch proposed patch (obsolete) — Splinter Review
Assignee: nobody → jdiggs
Status: NEW → ASSIGNED
Attachment #8881260 - Flags: review?(mzehe)
Comment on attachment 8881260 [details] [diff] [review]
proposed patch

Review of attachment 8881260 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/mac/mozAccessible.h
@@ +114,4 @@
>  // the accessible description (help text) of this particular instance.
>  - (NSString*)help;
>  
> +// returns the orientation (veritical, horizontal, or undefined)

Nit: vertical (one i too many). :-)
Attachment #8881260 - Flags: review?(mzehe) → review+
(Assignee)

Comment 3

2 years ago
(In reply to Marco Zehe (:MarcoZ) from comment #2)
> Comment on attachment 8881260 [details] [diff] [review]
> proposed patch
> 
> Review of attachment 8881260 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: accessible/mac/mozAccessible.h
> @@ +114,4 @@
> >  // the accessible description (help text) of this particular instance.
> >  - (NSString*)help;
> >  
> > +// returns the orientation (veritical, horizontal, or undefined)
> 
> Nit: vertical (one i too many). :-)

Ugh. Sorry and thanks! :)
Attachment #8881260 - Attachment is obsolete: true
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 4

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/47eb47a6237a
Expose aria-orientation via NSAccessibilityOrientationAttribute. r=MarcoZ
Keywords: checkin-needed

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/47eb47a6237a
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.