1376303 - Expose the value of aria-orientation via NSAccessibilityOrientationAttribute

Status: RESOLVED FIXED

(Core :: Disability Access APIs, enhancement)

Description

[Joanmarie Diggs]

Gecko doesn't expose the value of aria-orientation on macOS. (This support is already in place for ATK and IA2.)

Comment 1

[Joanmarie Diggs]

Attachment: proposed patch

Comment 2

[Marco Zehe (:MarcoZ)]

Comment on attachment 8881260 [details] [diff] [review]
proposed patch

Review of attachment 8881260 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/mac/mozAccessible.h
@@ +114,4 @@
>  // the accessible description (help text) of this particular instance.
>  - (NSString*)help;
>  
> +// returns the orientation (veritical, horizontal, or undefined)

Nit: vertical (one i too many). :-)

Comment 3

[Joanmarie Diggs]

Attachment: patch for landing

(In reply to Marco Zehe (:MarcoZ) from comment #2)
> Comment on attachment 8881260 [details] [diff] [review]
> proposed patch
> 
> Review of attachment 8881260 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: accessible/mac/mozAccessible.h
> @@ +114,4 @@
> >  // the accessible description (help text) of this particular instance.
> >  - (NSString*)help;
> >  
> > +// returns the orientation (veritical, horizontal, or undefined)
> 
> Nit: vertical (one i too many). :-)

Ugh. Sorry and thanks! :)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/47eb47a6237a
Expose aria-orientation via NSAccessibilityOrientationAttribute. r=MarcoZ

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/47eb47a6237a