Closed Bug 1376317 Opened 2 years ago Closed 2 years ago

Move the pref var cache for dom.placeholder.show_on_focus to nsContentUtils

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: ehsan, Assigned: ehsan)

Details

Attachments

(1 file)

While profiling Speedometer, I noticed that nsTextEditorState::UpdateOverlayTextVisibility() shows up as fairly hot.  Looking at this function under perf, most of the cost of the function goes towards checking the static sPrefCached variable for some reason, perhaps due to poor locality.  Moving this pref cache fully to nsContentUtils alleviates this dumb issue.
Attachment #8881265 - Flags: review?(bugs) → review+
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f7c45d2ed511
Move the pref var cache for dom.placeholder.show_on_focus to nsContentUtils; r=smaug
https://hg.mozilla.org/mozilla-central/rev/f7c45d2ed511
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Assignee: nobody → ehsan
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.