Closed
Bug 1376317
Opened 7 years ago
Closed 7 years ago
Move the pref var cache for dom.placeholder.show_on_focus to nsContentUtils
Categories
(Core :: DOM: Core & HTML, enhancement)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
Details
Attachments
(1 file)
|
4.92 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
While profiling Speedometer, I noticed that nsTextEditorState::UpdateOverlayTextVisibility() shows up as fairly hot. Looking at this function under perf, most of the cost of the function goes towards checking the static sPrefCached variable for some reason, perhaps due to poor locality. Moving this pref cache fully to nsContentUtils alleviates this dumb issue.
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8881265 -
Flags: review?(bugs)
|
||
Updated•7 years ago
|
Attachment #8881265 -
Flags: review?(bugs) → review+
Pushed by eakhgari@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f7c45d2ed511 Move the pref var cache for dom.placeholder.show_on_focus to nsContentUtils; r=smaug
|
||
Comment 3•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/f7c45d2ed511
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
|
||
Updated•6 years ago
|
Assignee: nobody → ehsan
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•