1376349 - mydashboard.html -> "Updated Since Last Visit" -> "Mark Visited" should do also a "Refresh"

Status: REOPENED

(bugzilla.mozilla.org :: MyDashboard, enhancement)

Description

[Tobias B. Besemer [:BesTo] (QA)]

In the page mydashboard.html, under the headline "Updated Since Last Visit", the function "Mark Visited", should also run the function "Refresh" after it.

Comment 1

[Dipankar Das]

Hi, 
I would like to work on this. Can you assign me this bug? 

And I am trying to contribute to open source for the first time. Can you please guide me a little?

Comment 2

[Tobias B. Besemer [:BesTo] (QA)]

I can assign you - but I can't help you much...

Comment 3

[Tobias B. Besemer [:BesTo] (QA)]

Adrian, can you act as a guide/mentor here?

Comment 4

[[DEACTIVATED] Adrian Gaudebert]

I think you have the wrong person here. I know nothing about bugzilla.

Comment 5

[Tobias B. Besemer [:BesTo] (QA)]

Adrian, sorry for tagging you wrongly here and thank you for your feedback!

Dipankar, do you wanna have a look on bug 1366482, or bug 1366483, were Adrian can act as a mentor for you?

Comment 6

[Dylan Hardison [:dylan] (he/him)]

Hey, my team would be happy to help. We're in the #bteam channel on irc.mozilla.org

The first step would be to get a checkout of https://github.com/mozilla-bteam/bmo and get it running with vagrant (see the README.rst file)

Comment 7

[Dipankar Das]

Tobias, I will definitely take a look at those two bugs and comment there. 

Dylan, I will get back to you once I am done setting it up with vagrant.

Comment 8

[Dylan Hardison [:dylan] (he/him)]

Since IRC dropped, I'll note here: the file you want to look at is *probably* extensions/MyDashboard/web/js/query.js

Somewhere around this code:

Y.one('#query_markread').on('click', function(e) {

you'd add code similar to the code in 
Y.one('#query_refresh').on('click', function(e) {

Comment 9

[Dipankar Das]

Dylan, the setup is done. Now, I will try to fix the bug.

I will go through this.
extensions/MyDashboard/web/js/query.js

Comment 10

[Tobias B. Besemer [:BesTo] (QA)]

Dipankar, should I CC you to more bugs you maybe wanna have a look at and you can maybe fix with your skills?

Beside bug 1366482 and bug 1366483 I should have two more for you... ;-)

Comment 11

[Tobias B. Besemer [:BesTo] (QA)]

(In reply to Dylan Hardison [:dylan] (he/him) from comment #8)
> [...] you'd add code similar to the code in 
> Y.one('#query_refresh').on('click', function(e) {

What's about just trigger this function, too?

Comment 12

[Dipankar Das]

Tobias, yes please cc me to all the 4 bugs.

Comment 13

[Dipankar Das]

(In reply to Tobias B. Besemer [:BesTo] (QA) from comment #11)
> (In reply to Dylan Hardison [:dylan] (he/him) from comment #8)
> > [...] you'd add code similar to the code in 
> > Y.one('#query_refresh').on('click', function(e) {
> 
> What's about just trigger this function, too?

Yeah, I have made some changes and asked Dylan to guide me through the next steps.

Comment 14

[Tobias B. Besemer [:BesTo] (QA)]

(In reply to Dipankar Das from comment #12)
> Tobias, yes please cc me to all the 4 bugs.

Dipankar, I give you this list of bugs I think it's maybe good to start with...

BMO: Bug 1152484, or bug 1376344
Socorro: Bug 1366482, or bug 1366483
Socorro or Breakpad: Bug 1376335

...and I assigned you to bug 1377632. Maybe you wanna start there with Socorro. ;-)

If you have "made a significant investment of time, with useful results, into Mozilla project-governed activities", you can add your name to the side: https://www.mozilla.org/credits/ ;-)
(Look at the bottom of the page to see how it works...)

If you wanna have more such bugs, feel free to reach out to me. ;-)

Comment 15

[Dipankar Das]

Yeah thanks, Tobias.

Comment 16

[Dipankar Das]

Dylan, I mailed you about the changes I made locally and would be great if you tell me what I am supposed to do next.

I did a pull request in github. Not sure whether it's correct way or not. Please review that and let me know if I need to change something. First time pulling a request in GitHub.

Comment 17

[Tobias B. Besemer [:BesTo] (QA)]

(In reply to Dipankar Das from comment #16)
> Dylan, I mailed you about the changes I made locally and would be great if
> you tell me what I am supposed to do next.

Normally can you attach your suggested fix to the bug for review and then ask for review.


> I did a pull request in github. Not sure whether it's correct way or not.
> Please review that and let me know if I need to change something. First time
> pulling a request in GitHub.

Normally on GitHub you can fill bugs too and then ask there for review and pull.


...but I guess Dylan will answer you on any way, too.


Btw.: I also CCed you to bug 1376338. Also a minor prob I reported.

Comment 18

[Dylan Hardison [:dylan] (he/him)]

We primarily accept pull requests. It looks like Sebastin went and created one from your fork: https://github.com/mozilla-bteam/bmo/pull/119

I'll get to review that on Monday. Congrats on your first patch!

Comment 19

[Dylan Hardison [:dylan] (he/him)]

Attachment: PR

Comment 20

[Dipankar Das]

Thanks Dylan and yeah Sebastin helped me with that.

Comment 21

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8882906 [details] [review]
PR

A very good first patch, I have updated the PR with a question and a suggested change.

Comment 22

[Dipankar Das]

Dylan, I tried to use "git rebase -i" for deleting an unwanted commit.
From then on, unable to push commits.(the corrected commit).
This is the error:-

git push fork bug-1376349

Username for 'https://github.com': dipanks
Password for 'https://[e-mail]': 
To https://github.com/Dipanks/bmo.git
 ! [rejected]        bug-1376349 -> bug-1376349 (non-fast-forward)
error: failed to push some refs to 'https://github.com/Dipanks/bmo.git'
hint: Updates were rejected because the tip of your current branch is behind
hint: its remote counterpart. Integrate the remote changes (e.g.
hint: 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.

I tried to use git reflog and hard reset head but with no success.
Any idea how to correct this?

Comment 23

[Dylan Hardison [:dylan] (he/him)]

You can add --force in this case.

Comment 24

[Dylan Hardison [:dylan] (he/him)]

that is, git push --force fork bug-1376349

Comment 25

[Dipankar Das]

Dylan, I pushed a commit just now. Will you check and let me know if it is okay?

I force pushed it and previous commits are not being shown.

Comment 26

[Tobias B. Besemer [:BesTo] (QA)]

Dipankar, do you want to attach here your patch for the stats, too? ;-)

Comment 27

[Dipankar Das]

I did not understand you. Tobias. What should I add?

Comment 28

[Tobias B. Besemer [:BesTo] (QA)]

Your patch (PR).
Guess that will count in your profiles stats (statistics).
PR was attached by Dylan.

Comment 29

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

I don't see a "mark visited" in Updated Since Last Visit on MyDashboard any longer.

Comment 30

[chrizilla]

Attachment: mark visited.png

(In reply to comment #29)

As visible in the attached screenshot, "mark visited" is still there (or back again).

On my end, "mark visited" does neither an automatic refresh (bug 1376349) nor marks the list items as visited (bug 1839194).