1376360 - Make FileMediaResource non-cloneable

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

FileMediaResource has no data to share. We can remove some call path by making it non-cloneable.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1376360. P1 - give CloneData() a default implementation for most resource types don't support clone.

Also remove CanClone() overrides that are identical to that of the base class.

Review commit: https://reviewboard.mozilla.org/r/152522/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/152522/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1376360. P2 - make FileMediaResource non-cloneable.

It doesn't make much sense to clone a FileMediaResource for they have no data to share.

Review commit: https://reviewboard.mozilla.org/r/152524/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/152524/

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1376360. P3 - remove the call path for null aStreamListener in FileMediaResource::Open().

Null aStreamListener is passed only when cloning.
Since we remove cloning in P2, we can now remove the call path.

Review commit: https://reviewboard.mozilla.org/r/152526/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/152526/

Comment 4

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8881330 [details]
Bug 1376360. P1 - give CloneData() a default implementation for most resource types don't support clone.

https://reviewboard.mozilla.org/r/152522/#review157770

Comment 5

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8881331 [details]
Bug 1376360. P2 - make FileMediaResource non-cloneable.

https://reviewboard.mozilla.org/r/152524/#review157772

Comment 6

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8881332 [details]
Bug 1376360. P3 - remove the call path for null aStreamListener in FileMediaResource::Open().

https://reviewboard.mozilla.org/r/152526/#review157774

Comment 7

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/422dec01c834
P1 - give CloneData() a default implementation for most resource types don't support clone. r=gerald
https://hg.mozilla.org/integration/autoland/rev/9f5ba3ccd82c
P2 - make FileMediaResource non-cloneable. r=gerald
https://hg.mozilla.org/integration/autoland/rev/9d65c2c21ef7
P3 - remove the call path for null aStreamListener in FileMediaResource::Open(). r=gerald

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/422dec01c834
https://hg.mozilla.org/mozilla-central/rev/9f5ba3ccd82c
https://hg.mozilla.org/mozilla-central/rev/9d65c2c21ef7