Closed
Bug 1376360
Opened 7 years ago
Closed 7 years ago
Make FileMediaResource non-cloneable
Categories
(Core :: Audio/Video: Playback, enhancement, P3)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: jwwang, Assigned: jwwang)
References
Details
Attachments
(3 files)
FileMediaResource has no data to share. We can remove some call path by making it non-cloneable.
Assignee | ||
Updated•7 years ago
|
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8881330 -
Flags: review?(gsquelart)
Attachment #8881331 -
Flags: review?(gsquelart)
Attachment #8881332 -
Flags: review?(gsquelart)
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8881330 [details] Bug 1376360. P1 - give CloneData() a default implementation for most resource types don't support clone. https://reviewboard.mozilla.org/r/152522/#review157770
Attachment #8881330 -
Flags: review?(gsquelart) → review+
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8881331 [details] Bug 1376360. P2 - make FileMediaResource non-cloneable. https://reviewboard.mozilla.org/r/152524/#review157772
Attachment #8881331 -
Flags: review?(gsquelart) → review+
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8881332 [details] Bug 1376360. P3 - remove the call path for null aStreamListener in FileMediaResource::Open(). https://reviewboard.mozilla.org/r/152526/#review157774
Attachment #8881332 -
Flags: review?(gsquelart) → review+
Assignee | ||
Comment 7•7 years ago
|
||
Thanks!
Pushed by jwwang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/422dec01c834 P1 - give CloneData() a default implementation for most resource types don't support clone. r=gerald https://hg.mozilla.org/integration/autoland/rev/9f5ba3ccd82c P2 - make FileMediaResource non-cloneable. r=gerald https://hg.mozilla.org/integration/autoland/rev/9d65c2c21ef7 P3 - remove the call path for null aStreamListener in FileMediaResource::Open(). r=gerald
Comment 9•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/422dec01c834 https://hg.mozilla.org/mozilla-central/rev/9f5ba3ccd82c https://hg.mozilla.org/mozilla-central/rev/9d65c2c21ef7
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•