Closed Bug 1376363 Opened 3 years ago Closed 3 years ago

Remove MediaResource::GetContentType()

Categories

(Core :: Audio/Video: Playback, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(3 files)

http://searchfox.org/mozilla-central/rev/b425854d9bbd49d5caf9baef3686e49ec91c17ec/dom/media/MediaDecoder.cpp#643

MediaDecoder::EnsureTelemetryReported() is the only caller.

By storing the container type in MediaDecoder, we will be able to remove the method.
Assignee: nobody → jwwang
Blocks: 1373160
Priority: -- → P3
Attachment #8882071 - Flags: review?(gsquelart)
Attachment #8882072 - Flags: review?(gsquelart)
Attachment #8882073 - Flags: review?(gsquelart)
Comment on attachment 8882071 [details]
Bug 1376363. P1 - store container type in MediaDecoder.

https://reviewboard.mozilla.org/r/153172/#review158360
Attachment #8882071 - Flags: review?(gsquelart) → review+
Comment on attachment 8882072 [details]
Bug 1376363. P2 - call ContainerType() in EnsureTelemetryReported().

https://reviewboard.mozilla.org/r/153174/#review158362
Attachment #8882072 - Flags: review?(gsquelart) → review+
Comment on attachment 8882073 [details]
Bug 1376363. P3 - remove MediaResource::GetContentType() and its friends.

https://reviewboard.mozilla.org/r/153176/#review158364
Attachment #8882073 - Flags: review?(gsquelart) → review+
Thanks for the review!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9525159c5199
P1 - store container type in MediaDecoder. r=gerald
https://hg.mozilla.org/integration/autoland/rev/686b77ecd957
P2 - call ContainerType() in EnsureTelemetryReported(). r=gerald
https://hg.mozilla.org/integration/autoland/rev/0e12b505a238
P3 - remove MediaResource::GetContentType() and its friends. r=gerald
You need to log in before you can comment on or make changes to this bug.