137641 - Publish fails if any of the (include images and other files) files cannot be found

Status: VERIFIED DUPLICATE of bug 134883

(SeaMonkey :: Composer, defect)

Description

[TucsonTester1]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.0rc1)
Gecko/20020413 Netscape6/6.2.1+
BuildID:    2002041306

If a page, including images, does not properly publish/upload, all attempts to
publish thereafter fail. 

Reproducible: Always
Steps to Reproduce:
1.Install/Launch NS.
2.Launch a new/blank Composer window.
3.Add content to page including an image.
4.Select file|publish as... and publish to an ftp site(include images using same
location as page).
5.Add another image to the page.
6.Select file|publish as... 
7.Ensure include images and other files is checked.
8.Select "Use this site sub-directory" and enter an invalid sub-directory name
to cause publish to fail.
9.Attempt to publish the page using a correct sub-directory.

Actual Results:  Publishing initially fails because of the invalid
sub-directory.  Subsequent attempts to re-publish the page also fail whether
sub-directory is correct or not.

Expected Results:  Page should publish properly if correct information is
included in the publish dialog.

All attempts to re-publish the page fail as long as the images remain on the
page.  If the images are removed, the page will publish.

Comment 1

[Charles Manske]

I suspect that this is related to bug 134883.

Comment 2

[Kathleen :Brade]

no, I don't think it's related to that bug.

This bug can be reproduced by specifying a bad directory and then removing the
sub directory in a subsequent publish attempt (no images necessary).

Charley--reassign this to me if you don't want to investigate it.

Comment 3

[Charles Manske]

Kathy: No, this is *exactly* the problem I described in bug 134883!
I'll add more comments in that bug. Duping this one.


*** This bug has been marked as a duplicate of 134883 ***

Comment 4

[sujay]

verified.

Comment 5

[Kathleen :Brade]

Reopening bug to get clarification.
I don't believe this is a duplicate because I was able to reproduce the publish
failure without images (and that has nothing to do with image urls).

Sujay, Michael--can you reproduce this problem with the following steps (based
on original steps)?

Steps to Reproduce:
1.Install/Launch NS.
2.Launch a new/blank Composer window.
3.Add text to page.
4.Select file|publish as... and publish to an ftp site.
5.Type more text.
6.Select file|publish as... 
7.Add a "invalid" sub-directory name to cause publish to fail.
8.Select file|publish as...
9.Attempt to publish the page using a correct sub-directory or without
sub-directory.

Comment 6

[michael wendell]

I am not able to reproduce this problem on the 04-29 build using Brade's
suggestion.  I am able to reproduce this bug everytime using the original steps
to reproduce, but only if I fill out the "HTTP address to browse to:" field.  

I think that this is more then likely a dupe of bug 134833.

Comment 7

[Charles Manske]

Following Kathy's steps in comment #5,
I fail to publish if I designate a bad directory (step 8). I see the appropriate
error messages and we are left with same page locaton as before.
Step 9: If I then try to publish to a valid subdirectory, it publishes
successfully and the page location is changed to the new subdirectory.
The original bug description is definitely a dup of bug 134883.

The scenario described by Kathy should be a separate bug, if it can be reproduced.

Comment 8

[Kathleen :Brade]

I withdraw my comments with the revised steps to reproduce.
I think this is a better test scenario that needs to be addressed and is not
directly related to bug 134883:

1. Launch new composer window
2. add content to page
3. add this image to page:  http://mozilla.org/images/foobar/image.jpeg
4. File > Publish As...
5. Pick site where successful publishing should occur, give filename, etc.
6. Click publish

Observation:  publishing fails
Expectation:  I expect publishing to succeed if a broken image is encountered.

Comment 9

[Charles Manske]

I can see where it would be better to not consider a publishing attempt a total
failure if only 1 or more image files fail because of a bad URL. I think this is
going to be tricky to do, however. Will investigate.

Comment 10

[michael wendell]

*** Bug 139619 has been marked as a duplicate of this bug. ***

Comment 11

[michael wendell]

Updating summary to cover all associated files.

Comment 12

[Charles Manske]

Comments from DSLMichael from bug 139619 to explain why we think it's a dup:

The problem here as I see it is that Excell is referencing non existant files in
the head tag when it creates an html file.
If you uncheck the option to "include images and other files" when publishing,
Composer is able to publish the document.
But if you check the option, Composer tries to upload the files: filelist.xml
editdata.mso and oledata.mso.  Which it cannot find because Excell did not
create these files (at least not in the location specified in the head tag).  

Comment 13

[Charles Manske]

This is fixed by the fix for bug 148425

Comment 14

[Charles Manske]

This is fixed by a combination of recently-fixed publishing bugs.
If a bad directory is used for an image, that *will* abort the entire publishing
session (you will see "Publish Failed" message in Progress dialog).
But we then restore the original page, so subsequent attempts to publish will 
succeed. The central issue for this bug was the URL adjustments done during 
publishing, fixed in bug 134883, so I'm going to dup this one to that.

*** This bug has been marked as a duplicate of 134883 ***

Comment 15

[Charles Manske]

Removing keywords since this is fixed

Comment 16

[sujay]

bulk verification.