1376413 - Color the titlebar in customize mode on macOS

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[:Gijs (he/him)]

Just like bug 1375973, in customize mode the title bar is also transparent/light, and as a result you can't read the text in background tabs.

Comment 1

[Robin Whittleton]

This seems to be WFM now on latest Nightly (macOS).

Comment 2

[:Gijs (he/him)]

(In reply to Robin Whittleton from comment #1)
> This seems to be WFM now on latest Nightly (macOS).

Yes, though the titlebar is still not dark - Johann, is that intentional?

Comment 3

[Johann Hofmann [:johannh]]

Not on a Mac right now, I'll let Nihanth figure this out since he was working on Mac titlebar coloring.

Comment 4

[:Gijs (he/him)]

FWIW, I suspect this is a function of the caching implemented in bug 1334642 and/or us not calling inferFromText() again when entering/leaving customize mode.

Comment 5

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1376413 - Color the titlebar in customize mode on macOS.

Review commit: https://reviewboard.mozilla.org/r/158612/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/158612/

Comment 6

[(inactive) Nihanth Subramanya [:nhnt11]]

Coloured titlebar in customize mode used to look ugly but now it's fine, we should do it.

Comment 7

[Dão Gottwald [:dao]]

Comment on attachment 8887709 [details]
Bug 1376413 - Color the titlebar in customize mode on macOS.

https://reviewboard.mozilla.org/r/158612/#review164028

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/058760087ee4
Color the titlebar in customize mode on macOS. r=dao

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/058760087ee4

Comment 11

[Deac Alin]

Attachment: Screen Shot 2017-08-11 at 15.43.47.png

Verified on latest Nightly Version 57.0a1 Build ID  20170811100330
As can be seen in the screenshot, the colour is still displayed as white with light grey text as Gijs commented:
> Just like bug 1375973, in customize mode the title bar is also
> transparent/light, and as a result you can't read the text in background
> tabs.

Is this intended ?Thank you

Comment 12

[(inactive) Nihanth Subramanya [:nhnt11]]

(In reply to Deac Alin from comment #11)
> Created attachment 8896250 [details]
> Screen Shot 2017-08-11 at 15.43.47.png
> 
> Verified on latest Nightly Version 57.0a1 Build ID  20170811100330
> As can be seen in the screenshot, the colour is still displayed as white
> with light grey text as Gijs commented:
> > Just like bug 1375973, in customize mode the title bar is also
> > transparent/light, and as a result you can't read the text in background
> > tabs.
> 
> Is this intended ?Thank you

I can't reproduce this anymore, can you please check and if it's still a problem, provide STR?

Comment 13

[Deac Alin]

(In reply to Nihanth Subramanya [:nhnt11] from comment #12)
> I can't reproduce this anymore, can you please check and if it's still a
> problem, provide STR?

The issue here is that the colour of the Title bar is not consistent when in normal screen mode vs Full screen mode. Also when checking/unchecking the Title bar box. My question, if this is intended, was around this scenario.

1. Open Nightly and go to Customize - Default theme
2. Check the Title bar box (observe the color of the Bar)
3. Uncheck the Title bar
4. Adjust to full screen by pressing the button on top right side
5. Check the title bar box

Comment 14

[Deac Alin]

Hi Nihanth, did you get the chance to look at this? Thank you

Comment 15

[Deac Alin]

Retested on the latest Nightly and cannot reproduce the issue anymore on Mac 10.12.5 . I will mark this as Verified Fixed. Thank you