Color the titlebar in customize mode on macOS

RESOLVED FIXED in Firefox 56

Status

()

Firefox
Theme
P1
normal
RESOLVED FIXED
2 months ago
2 days ago

People

(Reporter: Gijs, Assigned: nhnt11, NeedInfo)

Tracking

({regression})

55 Branch
Firefox 56
Unspecified
Mac OS X
regression
Points:
---
Bug Flags:
qe-verify +

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox54 unaffected, firefox55 unaffected, firefox56 fixed)

Details

(Whiteboard: [photon-visual][p3])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Reporter)

Description

2 months ago
Just like bug 1375973, in customize mode the title bar is also transparent/light, and as a result you can't read the text in background tabs.

Comment 1

2 months ago
This seems to be WFM now on latest Nightly (macOS).
(Reporter)

Comment 2

2 months ago
(In reply to Robin Whittleton from comment #1)
> This seems to be WFM now on latest Nightly (macOS).

Yes, though the titlebar is still not dark - Johann, is that intentional?
Flags: needinfo?(jhofmann)
Not on a Mac right now, I'll let Nihanth figure this out since he was working on Mac titlebar coloring.
Flags: needinfo?(jhofmann) → needinfo?(nhnt11)
(Reporter)

Updated

a month ago
See Also: → bug 1379981
(Reporter)

Updated

a month ago
Summary: Titles of background tabs are unreadable (light on light) in customize mode → In customize mode the tabstrip thinks it has a dark background (gets light icons) even though it doesn't
(Reporter)

Comment 4

a month ago
FWIW, I suspect this is a function of the caching implemented in bug 1334642 and/or us not calling inferFromText() again when entering/leaving customize mode.
(Reporter)

Updated

a month ago
Whiteboard: [photon-visual][triage]

Updated

a month ago
OS: Unspecified → Mac OS X

Updated

a month ago
Flags: qe-verify+
Priority: -- → P2
QA Contact: brindusa.tot
Whiteboard: [photon-visual][triage] → [photon-visual]

Updated

a month ago
Assignee: nobody → nhnt11
Status: NEW → ASSIGNED
Priority: P2 → P1
Whiteboard: [photon-visual] → [photon-visual][p3]

Updated

a month ago
Iteration: --- → 56.3 - Jul 24
Comment hidden (mozreview-request)
(Assignee)

Comment 6

a month ago
Coloured titlebar in customize mode used to look ugly but now it's fine, we should do it.
Flags: needinfo?(nhnt11)
Summary: In customize mode the tabstrip thinks it has a dark background (gets light icons) even though it doesn't → Color the titlebar in customize mode on macOS

Comment 7

a month ago
mozreview-review
Comment on attachment 8887709 [details]
Bug 1376413 - Color the titlebar in customize mode on macOS.

https://reviewboard.mozilla.org/r/158612/#review164028
Attachment #8887709 - Flags: review?(dao+bmo) → review+

Comment 8

a month ago
Pushed by nhnt11@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/058760087ee4
Color the titlebar in customize mode on macOS. r=dao
https://hg.mozilla.org/mozilla-central/rev/058760087ee4
Status: ASSIGNED → RESOLVED
Last Resolved: 29 days ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
status-firefox54: --- → unaffected
status-firefox55: --- → unaffected
status-firefox-esr52: --- → unaffected
(Assignee)

Updated

27 days ago
Duplicate of this bug: 1379981

Updated

25 days ago
See Also: bug 1379981

Comment 11

8 days ago
Created attachment 8896250 [details]
Screen Shot 2017-08-11 at 15.43.47.png

Verified on latest Nightly Version 57.0a1 Build ID  20170811100330
As can be seen in the screenshot, the colour is still displayed as white with light grey text as Gijs commented:
> Just like bug 1375973, in customize mode the title bar is also
> transparent/light, and as a result you can't read the text in background
> tabs.

Is this intended ?Thank you
Flags: needinfo?(nhnt11)
QA Contact: brindusa.tot → ovidiu.boca
You need to log in before you can comment on or make changes to this bug.