Closed Bug 1376420 Opened 5 years ago Closed 5 years ago

Fix strings for Preferences tracking protection section (re-org v2)

Categories

(Firefox :: Preferences, enhancement, P1)

enhancement

Tracking

()

VERIFIED FIXED
Firefox 56
Tracking Status
firefox56 --- fixed
firefox57 --- verified

People

(Reporter: flod, Assigned: rickychien)

References

Details

(Whiteboard: [photon-preference])

Attachments

(1 file)

Splitting into a different bug at this point.

> -<!ENTITY  trackingProtection.description       "Tracking is when companies collect information about you to build a profile and display content based on your browsing and personal data.">
> -<!ENTITY  trackingProtection.radioGroupLabel   "Block known tracking companies from displaying content">
> +<!ENTITY  trackingProtection.description       "Tracking is the collection of your browsing data across multiple websites. Tracking can be used to build a profile and display content based on your browsing and personal information.">
> +<!ENTITY  trackingProtection.radioGroupLabel   "Use Tracking Protection to block known trackers">

These string IDs should have been changed.

Please also add an explanation on why we have trackingProtectionPBM5.label and trackingProtectionPBM6.label, because it's all but clear from the localization file if you don't have access to the mock-ups.
Flags: needinfo?(rchien)
Status: NEW → ASSIGNED
Flags: needinfo?(rchien)
Priority: -- → P1
Whiteboard: [photon-preference] → [photon-preference][triage]
Not sure whether it is ok to add a comment in privacy.dtd. flod, could you take a look? thanks
Comment on attachment 8881431 [details]
Bug 1376420 - Fix strings for Preferences tracking protection section

https://reviewboard.mozilla.org/r/152578/#review157764

This is missing the most important part (rename the changed strings)

::: browser/locales/en-US/chrome/browser/preferences/privacy.dtd:18
(Diff revision 1)
>  <!ENTITY  trackingProtectionNever.accesskey    "n">
>  <!ENTITY  trackingProtectionLearnMore.label    "Learn more">
>  <!ENTITY  trackingProtectionExceptions.label   "Exceptions…">
>  <!ENTITY  trackingProtectionExceptions.accesskey "x">
>  
> +<!-- LOCALIZATION NOTE (trackingProtectionPBM5.label): use for privacy.trackingprotection.ui.enabled = true -->

This string is displayed if privacy.trackingprotection.ui.enabled is set to true. This current happens on the release and beta channel.

(Assuming this happens also on Beta by default)

::: browser/locales/en-US/chrome/browser/preferences/privacy.dtd:21
(Diff revision 1)
>  <!ENTITY  trackingProtectionExceptions.accesskey "x">
>  
> +<!-- LOCALIZATION NOTE (trackingProtectionPBM5.label): use for privacy.trackingprotection.ui.enabled = true -->
>  <!ENTITY trackingProtectionPBM5.label         "Use Tracking Protection in Private Windows">
>  <!ENTITY trackingProtectionPBM5.accesskey     "v">
> +<!-- LOCALIZATION NOTE (trackingProtectionPBM6.label): use for privacy.trackingprotection.ui.enabled = false -->

This string is displayed if privacy.trackingprotection.ui.enabled is set to false. This current happens on the nightly channel.
Attachment #8881431 - Flags: review?(francesco.lodolo) → review-
This current happens -> This currently happens
Flags: qe-verify+
QA Contact: hani.yacoub
Target Milestone: --- → Firefox 56
Whiteboard: [photon-preference][triage] → [photon-preference]
(In reply to Francesco Lodolo [:flod] from comment #0)
> Splitting into a different bug at this point.
> 
> > -<!ENTITY  trackingProtection.description       "Tracking is when companies collect information about you to build a profile and display content based on your browsing and personal data.">
> > -<!ENTITY  trackingProtection.radioGroupLabel   "Block known tracking companies from displaying content">
> > +<!ENTITY  trackingProtection.description       "Tracking is the collection of your browsing data across multiple websites. Tracking can be used to build a profile and display content based on your browsing and personal information.">
> > +<!ENTITY  trackingProtection.radioGroupLabel   "Use Tracking Protection to block known trackers">
> 
> These string IDs should have been changed.

Still not addressing this issue
https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_content_best_practices#Changing_existing_strings

You need to use a different string ID, you changed these strings in bug 1370190
flod, sorry for not paying attention for that string changes. Can you review that patch? thanks!
Flags: needinfo?(francesco.lodolo)
Comment on attachment 8881431 [details]
Bug 1376420 - Fix strings for Preferences tracking protection section

https://reviewboard.mozilla.org/r/152578/#review158332
Attachment #8881431 - Flags: review?(francesco.lodolo) → review+
Pushed by rchien@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7a9ce3c904ec
Fix strings for Preferences tracking protection section r=flod
https://hg.mozilla.org/mozilla-central/rev/7a9ce3c904ec
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Flags: needinfo?(francesco.lodolo)
Hi,
I'm not sure what should I verify in this bug, could anybody please provide us with some steps to reproduce?
Thanks.
Flags: needinfo?(francesco.lodolo)
(In reply to Hani Yacoub from comment #14)
> Hi,
> I'm not sure what should I verify in this bug, could anybody please provide
> us with some steps to reproduce?
> Thanks.

Not the bug assignee, but just confirm that these two strings are still there

> +<!ENTITY  trackingProtection.description       "Tracking is the collection of your browsing data across multiple websites. Tracking can be used to build a profile and display content based on your browsing and personal information.">
> +<!ENTITY  trackingProtection.radioGroupLabel   "Use Tracking Protection to block known trackers">
Flags: needinfo?(francesco.lodolo)
Build ID: 20170820100343
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0

Verified as fixed on Firefox Nightly 57.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.