1376468 - ProgressTracker::RemoveObserver does unnecessary hashtable lookups

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, enhancement, P3)

Comment 1

[Mats Palmgren (inactive)]

Attachment: Use Lookup instead of Get+Remove to avoid unnecessary hashtable lookups

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8881411 [details] [diff] [review]
Use Lookup instead of Get+Remove to avoid unnecessary hashtable lookups

Review of attachment 8881411 [details] [diff] [review]:
-----------------------------------------------------------------

::: image/ProgressTracker.cpp
@@ +472,5 @@
>    // Remove the observer from the list.
>    bool removed = mObservers.Write([=](ObserverTable* aTable) {
> +    if (auto entry = aTable->Lookup(observer)) {
> +      entry.Remove();
> +      return true;

Another valid use case for Remove() having a useful return value.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1cccacc0f442
Use Lookup instead of Get+Remove to avoid unnecessary hashtable lookups.  r=froydnj

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1cccacc0f442