Closed Bug 1376486 Opened 7 years ago Closed 7 years ago

Add an "Experimental Features" setting to nightly to enable progressive webapp installation

Categories

(Firefox for Android Graveyard :: General, enhancement)

Product:
Firefox for Android Graveyard
Component:
General
Version:
53 Branch
Platform:
All
Android
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox56 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 56
Tracking Flags:
Tracking Status
firefox56 --- verified

People

(Reporter: droeh, Assigned: walkingice)

Details

Attachments

(3 files)

Bug 1376486 - Add PWA experimental feature preference
59 bytes, text/x-review-board-request
daleharvey
: review+
sebastian
: review+
Details
Bug 1376486 - Toggle PWA function by Android preference
59 bytes, text/x-review-board-request
daleharvey
: review+
sebastian
: review+
Details
PWA preference
95.38 KB, image/png
Details 
We currently have some support for progressive web apps in nightly, but no way of enabling their installation short of manually adding "manifest.install.enabled" to about:config and setting it to true. We should have this exposed in settings like we do with custom tabs support.
Julian, is this something you can take a look at (or recommend someone who can)? Thanks!
Flags: needinfo?(walkingice0204)
Similar to Custom Tabs? Yes I think I could prepare patches for it!
Assignee: nobody → walkingice0204
Flags: needinfo?(walkingice0204)
If the wording is not good enough, please correct me.
How are android preferences set, is it possible for users without any android tools to be able to set this pref?
Flags: needinfo?(walkingice0204)
Attached image PWA preference — 
Yes, as the screenshot attachment, I added an preference option be same as Custom Tabs. User can enable it by menu/advance/Experimental-Features.

And this preference is only visible in nightly build.
Flags: needinfo?(walkingice0204)
Comment on attachment 8882508 [details]
Bug 1376486 - Add PWA experimental feature preference

https://reviewboard.mozilla.org/r/153624/#review159294

This is great thanks
Attachment #8882508 - Flags: review?(dharvey) → review+
Comment on attachment 8882509 [details]
Bug 1376486 - Toggle PWA function by Android preference

https://reviewboard.mozilla.org/r/153626/#review159296

This is great thanks
Attachment #8882509 - Flags: review?(dharvey) → review+
I think this should be on by default on Nightly as well. There's very little risk, as people still have to voluntarily navigate the deep menu to install a PWA.
OK! I changed the default value of preference to True
Comment on attachment 8882508 [details]
Bug 1376486 - Add PWA experimental feature preference

https://reviewboard.mozilla.org/r/153624/#review160278

::: mobile/android/base/locales/en-US/android_strings.dtd:298
(Diff revision 4)
>  <!ENTITY custom_tabs_menu_item_open_in "Open in &formatS;">
>  <!ENTITY custom_tabs_menu_footer "Powered by &brandShortName;">
>  <!-- Long-click title of CustomTabsActivity will copy URL to clipboard and display this hint -->
>  <!ENTITY custom_tabs_hint_url_copy "URL copied">
>  
> +<!ENTITY pref_pwa "Progressive Web App">

App -> Apps?

::: mobile/android/base/locales/en-US/android_strings.dtd:299
(Diff revision 4)
>  <!ENTITY custom_tabs_menu_footer "Powered by &brandShortName;">
>  <!-- Long-click title of CustomTabsActivity will copy URL to clipboard and display this hint -->
>  <!ENTITY custom_tabs_hint_url_copy "URL copied">
>  
> +<!ENTITY pref_pwa "Progressive Web App">
> +<!ENTITY pref_pwa_summary "When adding shortcut to home screen, to add along with manifest if the website is Progressive Web App">

This description is a bit confusing. Maybe we can use something like "Allow web apps to be added to the home screen"?

::: mobile/android/moz.configure:72
(Diff revision 4)
>  project_flag('MOZ_ANDROID_CUSTOM_TABS',
>               help='Enable support for Android custom tabs',
>               default=milestone.is_nightly)
>  
> +project_flag('MOZ_ANDROID_PWA',
> +             help='Enable support for Progressive Web App',

App -> Apps?
Attachment #8882508 - Flags: review?(s.kaspari) → review+
Comment on attachment 8882509 [details]
Bug 1376486 - Toggle PWA function by Android preference

https://reviewboard.mozilla.org/r/153626/#review160280
Attachment #8882509 - Flags: review?(s.kaspari) → review+
Comment on attachment 8882508 [details]
Bug 1376486 - Add PWA experimental feature preference

https://reviewboard.mozilla.org/r/153624/#review160278

> This description is a bit confusing. Maybe we can use something like "Allow web apps to be added to the home screen"?

Agree, better!
After discussion on IRC, we decide to set default value to be 'false'.
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/b89824019d10
Add PWA experimental feature preference r=daleharvey,sebastian
https://hg.mozilla.org/integration/autoland/rev/be43c8c849c6
Toggle PWA function by Android preference r=daleharvey,sebastian
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b89824019d10
https://hg.mozilla.org/mozilla-central/rev/be43c8c849c6
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Verified as fixed on Nightly 56.0a1 (2017-07-10). The PWA switch experiment was created and can turn on PWA installation.
Device: Motorola Nexus 6 (Android 7.0).
Status: RESOLVED → VERIFIED
status-firefox56: fixed → verified
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: