1376513 - Fix expected value for text-shadow serialization in file_keyframeeffect-getkeyframes.html and skip the test case for gecko

Status: RESOLVED FIXED

(Core :: DOM: Animation, enhancement)

Description

[Mantaroh Yoshinaga[:mantaroh]]

In Gecko, text-shadow's serialization is different from stylo.

For example, we set '1px 1px 2px rgb(0, 0, 0)' to text-shadow,

Gecko : "1px 1px 2px 0px rgb(0, 0, 0)"
Stylo : "1px 1px 2px rgb(0, 0, 0)"

Gecko contain the unnecessary forth length value, I'll fix this bug of gecko on bug 1374564, in this bug, I'll disable this test on gecko(i.e. stylo preference is disabled).

Comment 1

[Mantaroh Yoshinaga[:mantaroh]]

Attachment: Bug 1376513 - Fix expected value for serizalization value for text-shadow of mochitest and skip this test case on gecko.

Review commit: https://reviewboard.mozilla.org/r/152592/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/152592/

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8881460 [details]
Bug 1376513 - Fix expected value for serizalization value for text-shadow of mochitest and skip this test case on gecko.

https://reviewboard.mozilla.org/r/152592/#review157724

::: dom/animation/test/testcommon.js:347
(Diff revision 1)
> +function isStyloEnabled() {
> +  try {
> +    return SpecialPowers.getBoolPref('layout.css.servo.enabled');
> +  } catch(e) {
> +    return false;
> +  }
> +}

Whereas I used isServo name in test_keyframes_vendor_prefix.html, but we should use 'servo' word instead.

Comment 3

[Mantaroh Yoshinaga[:mantaroh]]

Comment on attachment 8881460 [details]
Bug 1376513 - Fix expected value for serizalization value for text-shadow of mochitest and skip this test case on gecko.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/152592/diff/1-2/

Comment 4

[Mantaroh Yoshinaga[:mantaroh]]

Comment on attachment 8881460 [details]
Bug 1376513 - Fix expected value for serizalization value for text-shadow of mochitest and skip this test case on gecko.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/152592/diff/2-3/

Comment 5

[Mantaroh Yoshinaga[:mantaroh]]

(In reply to Mantaroh Yoshinaga[:mantaroh] from comment #4)
> Comment on attachment 8881460 [details]
> Bug 1376513 - Fix expected value for serizalization value for text-shadow of
> mochitest and skip this test case on gecko.
> 
> Review request updated; see interdiff:
> https://reviewboard.mozilla.org/r/152592/diff/2-3/

Sorry, I wrote wrong patch, I need to reverse condition flag of stylo.
I rewrite and try it: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d1d7bcc3289bd6131aab4d67a73bc47962924124

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/69b1f05eb398
Fix expected value for serizalization value for text-shadow of mochitest and skip this test case on gecko. r=hiro

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/69b1f05eb398