Closed Bug 1376513 Opened 5 years ago Closed 5 years ago

Fix expected value for text-shadow serialization in file_keyframeeffect-getkeyframes.html and skip the test case for gecko

Categories

(Core :: DOM: Animation, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: mantaroh, Assigned: mantaroh)

Details

Attachments

(1 file)

In Gecko, text-shadow's serialization is different from stylo.

For example, we set '1px 1px 2px rgb(0, 0, 0)' to text-shadow,

Gecko : "1px 1px 2px 0px rgb(0, 0, 0)"
Stylo : "1px 1px 2px rgb(0, 0, 0)"

Gecko contain the unnecessary forth length value, I'll fix this bug of gecko on bug 1374564, in this bug, I'll disable this test on gecko(i.e. stylo preference is disabled).
Summary: Disable mochitest of text-shadow serialization on gecko. → Fix expected value for text-shadow serialization in file_keyframeeffect-getkeyframes.html and skip the test case for gecko
Assignee: nobody → mantaroh
Status: NEW → ASSIGNED
Comment on attachment 8881460 [details]
Bug 1376513 - Fix expected value for serizalization value for text-shadow of mochitest and skip this test case on gecko.

https://reviewboard.mozilla.org/r/152592/#review157724

::: dom/animation/test/testcommon.js:347
(Diff revision 1)
> +function isStyloEnabled() {
> +  try {
> +    return SpecialPowers.getBoolPref('layout.css.servo.enabled');
> +  } catch(e) {
> +    return false;
> +  }
> +}

Whereas I used isServo name in test_keyframes_vendor_prefix.html, but we should use 'servo' word instead.
Attachment #8881460 - Flags: review?(hikezoe) → review+
(In reply to Mantaroh Yoshinaga[:mantaroh] from comment #4)
> Comment on attachment 8881460 [details]
> Bug 1376513 - Fix expected value for serizalization value for text-shadow of
> mochitest and skip this test case on gecko.
> 
> Review request updated; see interdiff:
> https://reviewboard.mozilla.org/r/152592/diff/2-3/

Sorry, I wrote wrong patch, I need to reverse condition flag of stylo.
I rewrite and try it: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d1d7bcc3289bd6131aab4d67a73bc47962924124
Pushed by mantaroh@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/69b1f05eb398
Fix expected value for serizalization value for text-shadow of mochitest and skip this test case on gecko. r=hiro
https://hg.mozilla.org/mozilla-central/rev/69b1f05eb398
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.