Closed Bug 1376522 Opened 5 years ago Closed 5 years ago

Delete unused code in Matrix4x4::TransformBounds

Categories

(Core :: Graphics, enhancement)

Other Branch
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: kats, Assigned: kats)

References

Details

Attachments

(1 file)

http://searchfox.org/mozilla-central/rev/b425854d9bbd49d5caf9baef3686e49ec91c17ec/gfx/2d/Matrix.h#874-880

The "verts" array is never used. The function repeats the work using the "quad" array just below and uses that instead.
This dead code actually predates bug 1069417; it was introduced in bug 1157984, and then I shuffled it around in bug 1069417 without noticing it was dead.
Blocks: 1157984
No longer blocks: 1069417
Comment on attachment 8881466 [details]
Bug 1376522 - Remove unused code.

https://reviewboard.mozilla.org/r/152600/#review157792
Attachment #8881466 - Flags: review?(botond) → review+
Ah, sorry - I didn't go back in the history far enough!
https://hg.mozilla.org/mozilla-central/rev/51449b9ae0cf
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.