1376527 - Crash in mozilla::wr::LockExternalImage

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Marcia Knous [:marcia]]

This bug was filed from the Socorro interface and is 
report bp-3afeee47-cff4-4bb8-acf1-067ad0170627.
=============================================================

Seeing this crash with the latest nightly Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:56.0) Gecko/20100101 Firefox/56.0 ID:20170627100238 CSet: 53477d584130945864c4491632f88da437353356

STR:
1. Click on Firefox nightly in the dock, or a firefox window
2. Crash - 100% reproducible. WR is enabled.

Comment 1

[Sotaro Ikeda [:sotaro]]

:marcia, is the crash happen on another platform than mac?

Comment 2

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #1)
> :marcia, is the crash happen on another platform than mac?

:marcia, can you also check what will happen on debug build?

Comment 3

[Marcia Knous [:marcia]]

(In reply to Sotaro Ikeda [:sotaro] from comment #1)
> :marcia, is the crash happen on another platform than mac?

Not sure. I can check next week when I have access again to a Windows machine.

Comment 4

[Sotaro Ikeda [:sotaro]]

When I checked windows and linux, I did not see the crash for now. I do not have environment of mac this week :(

Comment 5

[Marcia Knous [:marcia]]

(In reply to Sotaro Ikeda [:sotaro] from comment #2)
> (In reply to Sotaro Ikeda [:sotaro] from comment #1)
> > :marcia, is the crash happen on another platform than mac?
> 
> :marcia, can you also check what will happen on debug build?

I can reproduce the crash in a debug build using my main Nightly profile, but haven't been able to do it with a clean profile. I will attach the terminal output.

Comment 6

[Marcia Knous [:marcia]]

Attachment: debug.txt

Comment 7

[Marcia Knous [:marcia]]

Adding to my STR in Comment 0, I do minimize the window first. When I do that and click on the icon or minimized window I get an immediate crash.

Comment 8

[Sotaro Ikeda [:sotaro]]

I am going to look into it next week.

Comment 9

[Darkspirit]

Nightly 56 build 20170701100250 @ macOS 10.12.5 Darwin 16.6.0
Can reliably reproduce with attachment of bug 1305298 comment 0 with webrender+webrendest enabled.

Meldungs-ID 	Sendedatum
bp-9311c21a-cd02-4615-9e40-28d0e0170701 01.07.17 23:27
bp-71060776-f272-4da1-9f73-d27c70170701 01.07.17 23:26

Comment 10

[Sotaro Ikeda [:sotaro]]

The crash seemed to happen when mWidget->PreRender() returned false in RendererOGL::Render().

When mWidget->PreRender() returned false, RendererOGL::Render() does not call wr_renderer_render(). It means that webrender::renderer does not handle pending_texture_updates. But even in this case, RenderThread assumed that pending_texture_updates was handled and call NotifyDidRender().
  https://dxr.mozilla.org/mozilla-central/source/gfx/webrender_bindings/RenderThread.cpp#174

Then CompositorBridgeParent::NotifyDidCompositeToPipeline() called and it calls WebRenderCompositableHolder::Update(). WebRenderCompositableHolder::Update() assumes external images' end of usages from epoch. But it is not correct when mWidget->PreRender() returned false.

Comment 11

[Sotaro Ikeda [:sotaro]]

mWidget->PreRender() could return false only on nsChildView::PreRender() on mac.

Comment 12

[Sotaro Ikeda [:sotaro]]

Attachment: path - Do not call NotifyDidRender when RendererOGL::Render() returned false

Comment 13

[Sotaro Ikeda [:sotaro]]

Attachment: path - Do not call NotifyDidRender when RendererOGL::Render() returned false

Update comments.

Comment 14

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f1f86f2ba1f526badffe0a547c1ec018d6972bbf

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/39b8e61c50e0
Do not call NotifyDidRender when RendererOGL::Render() returned false r=nical

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/39b8e61c50e0