Closed Bug 1376532 Opened 3 years ago Closed 3 years ago

Do crahs if CreateRenderTexture() is not implemented also on release build

Categories

(Core :: Graphics: WebRender, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: sotaro, Assigned: sotaro)

References

Details

Attachments

(1 file)

It is better to do crash if CreateRenderTexture() is not implemented yet also on release build.
See Also: → 1376527
Attachment #8881486 - Flags: review?(nical.bugzilla)
(In reply to Sotaro Ikeda [:sotaro] from comment #0)
> It is better to do crash if CreateRenderTexture() is not implemented yet
> also on release build.

Without it, we face a crash in a different place like LockExternalImage().
Attachment #8881486 - Flags: review?(nical.bugzilla) → review+
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2fb0d7773039
Do crahs if CreateRenderTexture() is not implemented also on release build r=nical
https://hg.mozilla.org/mozilla-central/rev/2fb0d7773039
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.