Closed Bug 1376544 Opened 3 years ago Closed 3 years ago
CSSFrame Constructor::Content Appended() calls ns Document::Get Layout History State() needlessly in most cases
This is used to initialize nsFrameConstructorState::mFrameState, but as far as I can tell, this information is only ever used when creating select frames, and nothing else, so it seems like we should be able to initialize this members lazily. This wasn't a huge cost under Speedometer profiles, but I kept noticing it. The fact that this is called from ContentAppended() makes this hurt us a lot every time a node is added, for example under HTMLInputElement.value setter.
Since I have landed bug 1375910, we keep text node even if input.value sets empty. It means that we don't create and insert text node every time on addItem-sync tests.
Interesting! This would be worth re-measuring I think.
This is now a very insignificant part of nsCSSFrameConstructor::ContentAppended().
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.