59 bytes, text/x-review-board-request
In bug 1322611 we simplified the code for running the crashreporter client by removing the Mac-specific path and replacing it with the fork()-based code path we use in Linux. As it turns out this is unreliable due to fork() trying to allocate memory on Mac; so we should revert to using posix_spawnp() instead.
Created attachment 8881532 [details] [diff] [review] [PATCH] WIP Here's a WIP for this. I don't have a Mac right now so I can't test it, but I should be able to test it tomorrow.
Assignee: nobody → gsvelto
Status: NEW → ASSIGNED
If you can push to try with this patch I can test it locally.
I've tested this locally at the all hands and it doesn't work because of the missing DYLD_LIBRARY_PATH in the environment. Feel free to pick this up while I'm on paternity leave, otherwise I'll fix it as soon as I'm back.
I've updated my patch and it seems to work correctly now, it was just a matter of setting DYLD_LIBRARY_PATH before launching the crashreporter client.
Attachment #8881532 - Attachment is obsolete: true
Comment on attachment 8896454 [details] bug 1376574 - Do not use fork() for launching the crashreporter on Mac since that might crash too; https://reviewboard.mozilla.org/r/167702/#review178688 Thanks for fixing this!
Attachment #8896454 - Flags: review?(ted) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/512c998741c5 Do not use fork() for launching the crashreporter on Mac since that might crash too; r=ted
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.