Closed Bug 1376574 Opened 3 years ago Closed 3 years ago

Use posix_spawnp() on Mac to launch the crashreporter to work around bug 1376567

Categories

(Toolkit :: Crash Reporting, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: gsvelto, Assigned: gsvelto)

References

Details

Attachments

(1 file, 1 obsolete file)

In bug 1322611 we simplified the code for running the crashreporter client by removing the Mac-specific path and replacing it with the fork()-based code path we use in Linux. As it turns out this is unreliable due to fork() trying to allocate memory on Mac; so we should revert to using posix_spawnp() instead.
Attached patch [PATCH] WIP (obsolete) — Splinter Review
Here's a WIP for this. I don't have a Mac right now so I can't test it, but I should be able to test it tomorrow.
Assignee: nobody → gsvelto
Status: NEW → ASSIGNED
If you can push to try with this patch I can test it locally.
Flags: needinfo?(gsvelto)
I've tested this locally at the all hands and it doesn't work because of the missing DYLD_LIBRARY_PATH in the environment. Feel free to pick this up while I'm on paternity leave, otherwise I'll fix it as soon as I'm back.
Flags: needinfo?(gsvelto)
I've updated my patch and it seems to work correctly now, it was just a matter of setting DYLD_LIBRARY_PATH before launching the crashreporter client.
Attachment #8881532 - Attachment is obsolete: true
Comment on attachment 8896454 [details]
bug 1376574 - Do not use fork() for launching the crashreporter on Mac since that might crash too;

https://reviewboard.mozilla.org/r/167702/#review178688

Thanks for fixing this!
Attachment #8896454 - Flags: review?(ted) → review+
Pushed by gsvelto@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/512c998741c5
Do not use fork() for launching the crashreporter on Mac since that might crash too; r=ted
https://hg.mozilla.org/mozilla-central/rev/512c998741c5
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.