Closed
Bug 1376592
Opened 7 years ago
Closed 7 years ago
rewrite docshell/test/navigation/test_triggeringprincipal_window_open.html
Categories
(Core :: DOM: Security, enhancement)
Core
DOM: Security
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: allstars.chh, Assigned: allstars.chh)
References
Details
(Whiteboard: [domsecurity-active])
Attachments
(1 file, 1 obsolete file)
|
2.37 KB,
patch
|
ckerschb
:
review+
|
Details | Diff | Splinter Review |
See the test in http://searchfox.org/mozilla-central/rev/fdb811340ac4e6b93703d72ee99217f3b1d250ac/docshell/test/navigation/test_triggeringprincipal_window_open.html#59 If we turn on the pref, dataWin.onload won't be called as now dataWin is cross origin.
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8881550 -
Flags: review?(ckerschb)
|
|
Assignee | |
Comment 2•7 years ago
|
||
rename the message "ok" to "loaded", checked if message matches
Attachment #8881550 -
Attachment is obsolete: true
Attachment #8881550 -
Flags: review?(ckerschb)
Attachment #8881581 -
Flags: review?(ckerschb)
|
||
Comment 3•7 years ago
|
||
Comment on attachment 8881581 [details] [diff] [review] Patch. v2 Review of attachment 8881581 [details] [diff] [review]: ----------------------------------------------------------------- thanks, r=me
Attachment #8881581 -
Flags: review?(ckerschb) → review+
Pushed by yhuang@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/3e09bfc94f23 rewrite test_triggeringprincipal_window_open.html. r=ckerschb
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/3e09bfc94f23
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•